From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Emanuele Giaquinta Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] Changes to emacs/src/emacs.c,v Date: Tue, 29 Jul 2008 15:40:21 +0200 Message-ID: <20080729134021.GB1130@orion.lan> References: <20080728224640.GB894@orion.lan> <200807282259.m6SMxLOj027630@sallyv1.ics.uci.edu> <20080728231851.GC894@orion.lan> <200807282328.m6SNScpc012745@sallyv1.ics.uci.edu> <20080729075853.GA1130@orion.lan> <200807291313.m6TDDUtf013397@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1217338903 14628 80.91.229.12 (29 Jul 2008 13:41:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Jul 2008 13:41:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 29 15:42:32 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KNpT9-0000lw-Lb for ged-emacs-devel@m.gmane.org; Tue, 29 Jul 2008 15:42:27 +0200 Original-Received: from localhost ([127.0.0.1]:36963 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNpSF-00085C-H6 for ged-emacs-devel@m.gmane.org; Tue, 29 Jul 2008 09:41:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KNpRI-0007T6-9S for emacs-devel@gnu.org; Tue, 29 Jul 2008 09:40:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KNpRD-0007PM-9R for emacs-devel@gnu.org; Tue, 29 Jul 2008 09:40:30 -0400 Original-Received: from [199.232.76.173] (port=42234 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNpRD-0007PE-4N for emacs-devel@gnu.org; Tue, 29 Jul 2008 09:40:27 -0400 Original-Received: from fk-out-0910.google.com ([209.85.128.184]:8604) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KNpRC-0000k8-Ck for emacs-devel@gnu.org; Tue, 29 Jul 2008 09:40:26 -0400 Original-Received: by fk-out-0910.google.com with SMTP id 18so3967224fkq.10 for ; Tue, 29 Jul 2008 06:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to; bh=ynnqTca62qrWNAtXdhTJTRiF+dhAwNeLW6+14vrHo6w=; b=ef5HtUTrzrCm+1EsqBuRYSGFBo9hY+lZECWR7fE8ieShH78GLd59vIqwxw2zn7RKQ5 BvxtL7urFU4VFnHkaTQT/o9ZFnL974zEjIvkO2ejLyX+6fJK88u5xJ1PPH3B/D6YZg/y 2wILIs0v0Bv2x8jx6QarHuc2RiAyqZ4H5m2ys= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to; b=xtWxCd3yRDHJM8PIHU+Zwj2mfyKOEVADt1mTf9i5GNCyvk9dA2IsSqCqefK4zn53by /+CJ2Tq7NLbDUzHWJwIqPfHkivXsc2UnBTbi1E0ocwAP9eV/NnTJLpAO4lUZyGlj3WFs jOL5jNmCJFwlZbc7CDQp8PsURsMOkAk1wE3tg= Original-Received: by 10.181.24.14 with SMTP id b14mr2090139bkj.22.1217338825059; Tue, 29 Jul 2008 06:40:25 -0700 (PDT) Original-Received: from localhost ( [82.53.45.190]) by mx.google.com with ESMTPS id z15sm4383671fkz.16.2008.07.29.06.40.23 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 29 Jul 2008 06:40:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <200807291313.m6TDDUtf013397@sallyv1.ics.uci.edu> X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101687 Archived-At: On Tue, Jul 29, 2008 at 06:13:30AM -0700, Dan Nicolaescu wrote: > Emanuele Giaquinta writes: > > > On Mon, Jul 28, 2008 at 04:28:38PM -0700, Dan Nicolaescu wrote: > > > > > Emanuele Giaquinta writes: > > > > > > > On Mon, Jul 28, 2008 at 03:59:21PM -0700, Dan Nicolaescu wrote: > > > > > > > > > Unfortunately that is not what the code in configure.in said: > > > > > > > > > > /* TODO: These are used for the Carbon port only. */ > > > > > #undef MAC_OS > > > > > #undef MAC_OSX > > > > > > > > > > What is the right conditional there? > > > > > > > > I think the right conditional is to check only MAC_OSX (defined in > > > > s/darwin.h), that code is required by unexmacosx.c. > > > > > > MAC_OSX is only define if !HAVE_NS, so that wouldn't be quite right > > > either. > > > > Ah, I see. The previous conditional was correct then. > > It would make this particular code work, but it might not be enough. > src/s/darwin.h should not be using -DMAC_OSX, it should put that in a > #define, that is the point of darwin.h, to contain #defines. The macro > should be documented properly in admin/CPP-DEFINES. Hopefully a mac > person can take care of this. While I agree that using a #define rather than -D would be nicer, I do not see what it would change wrt this issue. MAC_OSX was documented in CPP-DEFINES, maybe the description could have been better but I do not see what is wrong in reverting that hunk that is not related to the carbon gui removal and breaks non toolkit builds, the whole thing can be improved later if needed. Emanuele