From: Dan Nicolaescu <dann@ics.uci.edu>
To: Emanuele Giaquinta <emanuele.giaquinta@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] Changes to emacs/src/emacs.c,v
Date: Tue, 29 Jul 2008 06:13:30 -0700 [thread overview]
Message-ID: <200807291313.m6TDDUtf013397@sallyv1.ics.uci.edu> (raw)
In-Reply-To: <20080729075853.GA1130@orion.lan> (Emanuele Giaquinta's message of "Tue, 29 Jul 2008 09:58:53 +0200")
Emanuele Giaquinta <emanuele.giaquinta@gmail.com> writes:
> On Mon, Jul 28, 2008 at 04:28:38PM -0700, Dan Nicolaescu wrote:
>
> > Emanuele Giaquinta <emanuele.giaquinta@gmail.com> writes:
> >
> > > On Mon, Jul 28, 2008 at 03:59:21PM -0700, Dan Nicolaescu wrote:
> > >
> > > > Unfortunately that is not what the code in configure.in said:
> > > >
> > > > /* TODO: These are used for the Carbon port only. */
> > > > #undef MAC_OS
> > > > #undef MAC_OSX
> > > >
> > > > What is the right conditional there?
> > >
> > > I think the right conditional is to check only MAC_OSX (defined in
> > > s/darwin.h), that code is required by unexmacosx.c.
> >
> > MAC_OSX is only define if !HAVE_NS, so that wouldn't be quite right
> > either.
>
> Ah, I see. The previous conditional was correct then.
It would make this particular code work, but it might not be enough.
src/s/darwin.h should not be using -DMAC_OSX, it should put that in a
#define, that is the point of darwin.h, to contain #defines. The macro
should be documented properly in admin/CPP-DEFINES. Hopefully a mac
person can take care of this.
next prev parent reply other threads:[~2008-07-29 13:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1KNAva-0007QI-CF@cvs.savannah.gnu.org>
2008-07-28 22:46 ` [Emacs-diffs] Changes to emacs/src/emacs.c,v Emanuele Giaquinta
2008-07-28 22:59 ` Dan Nicolaescu
2008-07-28 23:18 ` Emanuele Giaquinta
2008-07-28 23:28 ` Dan Nicolaescu
2008-07-29 7:58 ` Emanuele Giaquinta
2008-07-29 13:13 ` Dan Nicolaescu [this message]
2008-07-29 13:40 ` Emanuele Giaquinta
2008-07-29 14:00 ` Dan Nicolaescu
2008-07-29 2:47 ` Stefan Monnier
2008-07-29 4:43 ` Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807291313.m6TDDUtf013397@sallyv1.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=emanuele.giaquinta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).