From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] Changes to emacs/src/emacs.c,v Date: Mon, 28 Jul 2008 21:43:00 -0700 Message-ID: <200807290443.m6T4h1s3011785@sallyv1.ics.uci.edu> References: <20080728224640.GB894@orion.lan> <200807282259.m6SMxLOj027630@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1217306735 15681 80.91.229.12 (29 Jul 2008 04:45:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Jul 2008 04:45:35 +0000 (UTC) Cc: Emanuele Giaquinta , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 29 06:46:24 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KNh6H-0005hM-Py for ged-emacs-devel@m.gmane.org; Tue, 29 Jul 2008 06:46:18 +0200 Original-Received: from localhost ([127.0.0.1]:36953 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNh5M-0001tu-7y for ged-emacs-devel@m.gmane.org; Tue, 29 Jul 2008 00:45:20 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KNh5I-0001tp-JN for emacs-devel@gnu.org; Tue, 29 Jul 2008 00:45:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KNh5H-0001td-KI for emacs-devel@gnu.org; Tue, 29 Jul 2008 00:45:16 -0400 Original-Received: from [199.232.76.173] (port=33340 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNh5H-0001ta-Ga for emacs-devel@gnu.org; Tue, 29 Jul 2008 00:45:15 -0400 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]:35088) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1KNh5G-0005gv-WB for emacs-devel@gnu.org; Tue, 29 Jul 2008 00:45:15 -0400 X-ICS-MailScanner-Watermark: 1217911385.32254@Fmd89vTkZTFirjATO77M1g Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m6T4h1s3011785; Mon, 28 Jul 2008 21:43:01 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Mon, 28 Jul 2008 22:47:21 -0400") Original-Lines: 18 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=0.521, required 5, autolearn=disabled, ALL_TRUSTED -1.44, URIBL_BLACK 1.96) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101670 Archived-At: Stefan Monnier writes: > >> This hunk is wrong and breaks malloc on os x when building without > >> toolkit. The reason to have two macros, MAC_OSX and HAVE_CARBON, was to > >> distinguish bare os x support from carbon gui AFAIU. > > > Unfortunately that is not what the code in configure.in said: > > But that's partly what admin/CPP-DEFINES says. The configure.in info was the most recent addition, so it looked like the most reliable source of information. But that code never worked correctly, puttin #undefine inside an AH_BOTTOM() has no effect, the code will be output commented out. (There are some more instances of using #undef in configure.in ... ) So the NS code was clearly never tested with MAC_OSX undefined, so it won't be too surprising if there are more problems of the same kind.