From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: some missing code? (was: Re: Emacs.app merged) Date: Sun, 27 Jul 2008 13:12:37 -0700 Message-ID: <200807272012.m6RKCbwb010910@sallyv1.ics.uci.edu> References: <1C66F1FC-BF82-4365-944D-ADCC4D1F435C@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1217189987 8512 80.91.229.12 (27 Jul 2008 20:19:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Jul 2008 20:19:47 +0000 (UTC) Cc: emacs- devel To: Adrian Robert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 27 22:20:37 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KNCjM-0005Ho-7m for ged-emacs-devel@m.gmane.org; Sun, 27 Jul 2008 22:20:36 +0200 Original-Received: from localhost ([127.0.0.1]:44791 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNCiS-0007ei-5K for ged-emacs-devel@m.gmane.org; Sun, 27 Jul 2008 16:19:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KNCe6-0000xs-FB for emacs-devel@gnu.org; Sun, 27 Jul 2008 16:15:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KNCe5-0000vt-9N for emacs-devel@gnu.org; Sun, 27 Jul 2008 16:15:09 -0400 Original-Received: from [199.232.76.173] (port=48665 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNCe5-0000vY-2h for emacs-devel@gnu.org; Sun, 27 Jul 2008 16:15:09 -0400 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]:60760) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1KNCe4-0002TZ-GV for emacs-devel@gnu.org; Sun, 27 Jul 2008 16:15:09 -0400 X-ICS-MailScanner-Watermark: 1217794358.41594@DVGTon68BCg7Bw7umlCVJw Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m6RKCbwb010910; Sun, 27 Jul 2008 13:12:37 -0700 (PDT) In-Reply-To: <1C66F1FC-BF82-4365-944D-ADCC4D1F435C@gmail.com> (Adrian Robert's message of "Tue, 15 Jul 2008 14:47:21 -0400") Original-Lines: 58 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101589 Archived-At: I noticed that this function in frame.el does not have a check for ns, shouldn't it? (defun face-set-after-frame-default (frame &optional parameters) "Initialize the frame-local faces of FRAME. Calculate the face definitions using the face specs, custom theme settings, X resources, and `face-new-frame-defaults'. Finally, apply any relevant face attributes found amongst the frame parameters in PARAMETERS and `default-frame-alist'." (dolist (face (nreverse (face-list))) (condition-case () (progn ;; Initialize faces from face spec and custom theme. (face-spec-recalc face frame) ;; X resouces for the default face are applied during ;; x-create-frame. (and (not (eq face 'default)) (memq (window-system frame) '(x w32)) ^^^^^^^^^ (make-face-x-resource-internal face frame)) "x-create-frame" does not do a copy_alist at the beginning like the other ports to. On Windows not having that resulted in some strange behavior. It might be a good idea to sync that function with the X version again. What is the #ifdef HAVE_NS code in frame.c:x_get_frame used for? Lisp_Object lower; lower = Fdowncase (tem); if (!strcmp (SDATA (lower), "on") #ifdef HAVE_NS || !strcmp(SDATA(lower), "yes") #endif || !strcmp (SDATA (lower), "true")) return Qt; else if (!strcmp (SDATA (lower), "off") #ifdef HAVE_NS || !strcmp(SDATA(lower), "no") #endif || !strcmp (SDATA (lower), "false")) return Qnil; else return Fintern (tem, Qnil); Is "yes" and "no" something that some other program on the system can write? Or something that the user would write? If the latter, then wouldn't it be better to just teach the users to use the values all other systems uses and avoid complications in code and docs? Please take a look. Thanks --dan