From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: unable to copy directory recursively to a vfat partition Date: Wed, 23 Jul 2008 18:51:50 -0400 Message-ID: <20080723185150.txs6e4gbr23ow0g4@webmail.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1216853634 3315 80.91.229.12 (23 Jul 2008 22:53:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Jul 2008 22:53:54 +0000 (UTC) Cc: emacs-devel@gnu.org To: Sven Joachim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 24 00:54:42 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KLnE9-0004Di-Q7 for ged-emacs-devel@m.gmane.org; Thu, 24 Jul 2008 00:54:41 +0200 Original-Received: from localhost ([127.0.0.1]:39182 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLnD6-0000yS-FC for ged-emacs-devel@m.gmane.org; Wed, 23 Jul 2008 18:53:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KLnCG-0000gK-Lc for emacs-devel@gnu.org; Wed, 23 Jul 2008 18:52:36 -0400 Original-Received: from [199.232.76.173] (port=36873 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLnCG-0000g7-9s for emacs-devel@gnu.org; Wed, 23 Jul 2008 18:52:36 -0400 Original-Received: from south-station-annex.mit.edu ([18.72.1.2]:43869) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KLnCF-00083c-Br for emacs-devel@gnu.org; Wed, 23 Jul 2008 18:52:36 -0400 Original-Received: from grand-central-station.mit.edu (GRAND-CENTRAL-STATION.MIT.EDU [18.7.21.82]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id m6NMpxO8013680; Wed, 23 Jul 2008 18:52:03 -0400 (EDT) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by grand-central-station.mit.edu (8.13.6/8.9.2) with ESMTP id m6NMppaV020403; Wed, 23 Jul 2008 18:51:51 -0400 (EDT) Original-Received: from w92-130-webmail-1.mit.edu (WEBMAIL-SNAT.MIT.EDU [18.7.22.108]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id m6NMpoES006454; Wed, 23 Jul 2008 18:51:51 -0400 (EDT) Original-Received: (from nobody@localhost) by w92-130-webmail-1.mit.edu (8.12.4) id m6NMpoQ5009087; Wed, 23 Jul 2008 18:51:50 -0400 Original-Received: from CYD.MIT.EDU (CYD.MIT.EDU [18.115.2.24]) (User authenticated as cyd@ATHENA.MIT.EDU) by webmail.mit.edu (Horde MIME library) with HTTP; Wed, 23 Jul 2008 18:51:50 -0400 Content-Disposition: inline User-Agent: Internet Messaging Program (IMP) H3 (4.0.3) X-Scanned-By: MIMEDefang 2.42 X-Spam-Score: -2.599 X-detected-kernel: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101344 Archived-At: Regarding bug 268 in the bug tracker: > Copying a directory recursively in dired to a vfat partition fails > because `dired-copy-file-recursive' calls `set-file-modes' on > directories after creating them. This behaviour appears to be > new in 22.2, same recursive copy worked in 22.1. This appears to be due to the following change: 2007-10-31 Sven Joachim * dired-aux.el (dired-copy-file-recursive): Preserve directory permissions. Could someone fix this in both the trunk and the branch? It looks like a simple condition-case around the call to set-file-modes in dired-copy-file-recursive should be enough; but someone with access to vfat needs to test this.