unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: crash@vmlinux.org (Joachim Nilsson)
To: "Andrew W. Nosenko" <andrew.w.nosenko@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: lisp/progmodes/cc-styles.el indentation broken in ellemtel mode
Date: Thu, 17 Jul 2008 02:53:41 +0200	[thread overview]
Message-ID: <20080717005341.GA26458@vmlinux.org> (raw)
In-Reply-To: <6161f3180807160825t7014be0au266dfb38ca929313@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

On Wed, Jul 16, 2008 at 06:25:55PM +0300, Andrew W. Nosenko wrote:
> On Tue, Jul 15, 2008 at 3:44 PM, Joachim Nilsson <crash@vmlinux.org> wrote:
> > The Ellemtel C/C++ indentation engine has been broken on trunk since
> > around March.
> Beside removing (arglist-cont-nonempty) from the c-offsets-alist, you
> need add it to the c-hanging-braces-alist, just like it done for all
> other styles.  IMHO, current difference of "ellemtel" from an other
> styles was just a typo.

Yep, that seems about right.  Attached is a revised patch.

Regards
 /Jocke

[-- Attachment #2: cc-styles.diff --]
[-- Type: text/plain, Size: 1094 bytes --]

Index: lisp/progmodes/cc-styles.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/progmodes/cc-styles.el,v
retrieving revision 1.51
diff -u -r1.51 cc-styles.el
--- lisp/progmodes/cc-styles.el	6 May 2008 07:18:15 -0000	1.51
+++ lisp/progmodes/cc-styles.el	17 Jul 2008 00:45:35 -0000
@@ -162,15 +162,15 @@
     ("ellemtel"
      (c-basic-offset . 3)
      (c-comment-only-line-offset . 0)
-     (c-hanging-braces-alist     . ((substatement-open before after)))
+     (c-hanging-braces-alist     . ((substatement-open before after)
+				    (arglist-cont-nonempty)))
      (c-offsets-alist . ((topmost-intro        . 0)
 			 (substatement         . +)
 			 (substatement-open    . 0)
                          (case-label           . +)
                          (access-label         . -)
-                         (inclass              . ++)
-			 (inline-open          . 0)
-			 (arglist-cont-nonempty))))
+                         (inclass              . +)
+			 (inline-open          . 0))))
 
     ("linux"
      (c-basic-offset  . 8)

  reply	other threads:[~2008-07-17  0:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-15 12:44 lisp/progmodes/cc-styles.el indentation broken in ellemtel mode Joachim Nilsson
2008-07-16 15:25 ` Andrew W. Nosenko
2008-07-17  0:53   ` Joachim Nilsson [this message]
2008-07-27 17:37     ` For 23.1 release ... please. (Was: Re: lisp/progmodes/cc-styles.el indentation broken in ellemtel mode) Joachim Nilsson
2008-07-31 14:02       ` For 23.1 release ... please Chong Yidong
2008-07-31 14:08         ` Eric Lilja
2008-07-31 14:24           ` Chong Yidong
2008-08-01  5:19             ` Joachim Nilsson
2008-08-01 10:07               ` Eric Lilja
2008-08-01 10:38       ` For 23.1 release ... please. (Was: Re: lisp/progmodes/cc-styles.el indentation broken in ellemtel mode) Andrew W. Nosenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080717005341.GA26458@vmlinux.org \
    --to=crash@vmlinux.org \
    --cc=andrew.w.nosenko@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).