termios tab expansion on darwin

termios tab expansion on darwin

[Emanuele Giaquinta]

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

Hi,

the os headers in src/s/ for *BSD and darwin define TAB3 to OXTABS,
which is the equivalent of TAB3 on those systems to control tab
expansion. On darwin-8 sys/termios.h defines TAB3 though (to a no-op
flag it seems), and since sysdep.c includes config.h (which includes
the os header in s/) before sys/termios.h, TAB3 is redefined (as
it can be seen using -Wsystem-headers) to the no-op flag. The effect
is that tab expansion is not disabled, so if it is originally active
for the terminal from which emacs is started (which is the case for
xterm) it will cause cursor movements performed with tabs to corrupt
the display. The attached patch fixes it, not sure if it is the best
approach though.

Emanuele

[-- Attachment #2: oxtabs.diff --]
[-- Type: text/x-diff, Size: 424 bytes --]

diff --git a/src/s/darwin.h b/src/s/darwin.h
index aa509b7..0cc95f1 100644
--- a/src/s/darwin.h
+++ b/src/s/darwin.h
@@ -216,6 +216,8 @@ along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.  */
 
 /* System uses OXTABS instead of the expected TAB3.  (Copied from
    bsd386.h.)  */
+#include <sys/termios.h>
+#undef TAB3
 #define TAB3 OXTABS
 
 /* Darwin ld insists on the use of malloc routines in the System

Re: termios tab expansion on darwin

[Stefan Monnier]

> diff --git a/src/s/darwin.h b/src/s/darwin.h
> index aa509b7..0cc95f1 100644
> --- a/src/s/darwin.h
> +++ b/src/s/darwin.h
> @@ -216,6 +216,8 @@ along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.  */
 
>  /* System uses OXTABS instead of the expected TAB3.  (Copied from
>     bsd386.h.)  */
> +#include <sys/termios.h>
> +#undef TAB3
>  #define TAB3 OXTABS
 
>  /* Darwin ld insists on the use of malloc routines in the System

Thanks.  Can someone write an autoconf rule for that instead?


        Stefan

Re: termios tab expansion on darwin

[Emanuele Giaquinta]

On Mon, Jul 07, 2008 at 09:28:15PM -0400, Stefan Monnier wrote:

> Thanks.  Can someone write an autoconf rule for that instead?

If TAB3 is defined, only a runtime test can reveal if it is indeed the
correct flag. Or do you mean defining a macro depending on the
host?

Re: termios tab expansion on darwin

[Emanuele Giaquinta]

On Tue, Jul 08, 2008 at 01:08:42AM +0200, Emanuele Giaquinta wrote:

> the os headers in src/s/ for *BSD and darwin define TAB3 to OXTABS,
> which is the equivalent of TAB3 on those systems to control tab
> expansion. On darwin-8 sys/termios.h defines TAB3 though (to a no-op
> flag it seems), and since sysdep.c includes config.h (which includes
> the os header in s/) before sys/termios.h, TAB3 is redefined (as
> it can be seen using -Wsystem-headers) to the no-op flag. The effect
> is that tab expansion is not disabled, so if it is originally active
> for the terminal from which emacs is started (which is the case for
> xterm) it will cause cursor movements performed with tabs to corrupt
> the display. The attached patch fixes it, not sure if it is the best
> approach though.

ping?

Emanuele