From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Emanuele Giaquinta Newsgroups: gmane.emacs.devel Subject: Re: autoloads question Date: Mon, 12 May 2008 16:59:08 +0200 Message-ID: <20080512145908.GD8357@orion.lan> References: <20080512100900.GA8357@orion.lan> <20080512105245.GC8357@orion.lan> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1210604380 14679 80.91.229.12 (12 May 2008 14:59:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 12 May 2008 14:59:40 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 12 17:00:16 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JvZVV-0002kl-NK for ged-emacs-devel@m.gmane.org; Mon, 12 May 2008 17:00:05 +0200 Original-Received: from localhost ([127.0.0.1]:44985 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JvZUn-0002p7-An for ged-emacs-devel@m.gmane.org; Mon, 12 May 2008 10:59:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JvZUj-0002os-Pg for emacs-devel@gnu.org; Mon, 12 May 2008 10:59:17 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JvZUh-0002nJ-B5 for emacs-devel@gnu.org; Mon, 12 May 2008 10:59:16 -0400 Original-Received: from [199.232.76.173] (port=39551 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JvZUh-0002nB-4W for emacs-devel@gnu.org; Mon, 12 May 2008 10:59:15 -0400 Original-Received: from mu-out-0910.google.com ([209.85.134.188]:46338) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JvZUf-0007y8-VR for emacs-devel@gnu.org; Mon, 12 May 2008 10:59:14 -0400 Original-Received: by mu-out-0910.google.com with SMTP id i2so1207922mue.6 for ; Mon, 12 May 2008 07:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to; bh=Wo8GchQpDyQck26UI5K2ELnYPvOw0oaeSlKYYkEaO/U=; b=YqO2K0h49D66j8KN0OnMu0mhm7muXfYg02ef2mzrIJdmjTInSbq+3oOlHElKUVg/e7QUBTcyXrFL8XQhjS6TxH5sd3nJVvdUhYkV9vNE0kzd/r7Fkkx8XRLznODv89jl0Pv/ZKLloTMlB1WJTefhD6cVex1sUBMu4SGLYCBwuxs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to; b=J86/FWue+rlAC+Q/tDnzk0p1P8JdLHwsCG7EViXn96rg7UX974Se8ZSNK04N0Q7p0AXlizq/d1PignF2u7dqKu/E5JClp6m+KGC64kobv1HtBTgfHrnT62nH2m3/Ijh1MVO75pCnIcqaKJvaY0gXPR+iS7PAu5gPPPK7I7dT1Yg= Original-Received: by 10.86.51.2 with SMTP id y2mr14388118fgy.52.1210604352739; Mon, 12 May 2008 07:59:12 -0700 (PDT) Original-Received: from localhost ( [87.17.86.50]) by mx.google.com with ESMTPS id e11sm6088165fga.1.2008.05.12.07.59.10 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 12 May 2008 07:59:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97029 Archived-At: On Mon, May 12, 2008 at 10:28:01AM -0400, Stefan Monnier wrote: > >>>>> "Emanuele" == Emanuele Giaquinta writes: > > > On Mon, May 12, 2008 at 12:42:09PM +0200, Juanma Barranquero wrote: > >> On Mon, May 12, 2008 at 12:09 PM, Emanuele Giaquinta > >> wrote: > >> > >> > -;;;;;; "widget.el" "window.el" "x-dnd.el") (18472 4851 825214)) > >> > +;;;;;; "widget.el" "window.el" "x-dnd.el") (18472 4853 658506)) > >> > > >> > Is it expected? > >> > >> That is a timestamp. > > > Ah I see, thanks. > > It is a bit boring because it causes an unneeded rebuild of emacs. > > I use the patch below to avoid the problem, > @@ -632,7 +725,12 @@ > (current-buffer) nil nil no-autoloads this-time) > (insert generate-autoload-section-trailer)) > > - (save-buffer) > + ;; Don't modify the file if its content has not been changed, so make > + ;; dependencies don't trigger unnecessarily. This fails to update the > + ;; time-stamp of the `no-autoloads' section, so it may cause redundant > + ;; scans of files in future invocations. I.e. it's a trade-off. > + (when changed (save-buffer)) > + > ;; In case autoload entries were added to other files because of > ;; file-local autoload-generated-file settings. > (autoload-save-buffers)))) > Wouldn't it be better to save the file mtime and restore it with set-file-times if changed is nil? Emanuele