From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric S. Raymond" Newsgroups: gmane.emacs.devel Subject: Re: Redesigh of the VC front end Date: Tue, 6 May 2008 04:28:26 -0400 Organization: Eric Conspiracy Secret Labs Message-ID: <20080506082826.GD23773@thyrsus.com> References: <20080506003943.80ED89F054C@snark.thyrsus.com> <200805060114.m461EZ05007471@sallyv1.ics.uci.edu> Reply-To: esr@thyrsus.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1210062716 22869 80.91.229.12 (6 May 2008 08:31:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 May 2008 08:31:56 +0000 (UTC) Cc: "Eric S. Raymond" , emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 06 10:32:31 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JtIas-0008Ty-Cy for ged-emacs-devel@m.gmane.org; Tue, 06 May 2008 10:32:14 +0200 Original-Received: from localhost ([127.0.0.1]:42153 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtIaA-0002U7-HK for ged-emacs-devel@m.gmane.org; Tue, 06 May 2008 04:31:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JtIWY-0001Ff-Td for emacs-devel@gnu.org; Tue, 06 May 2008 04:27:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JtIWY-0001FG-3x for emacs-devel@gnu.org; Tue, 06 May 2008 04:27:46 -0400 Original-Received: from [199.232.76.173] (port=48113 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtIWY-0001F9-0J for emacs-devel@gnu.org; Tue, 06 May 2008 04:27:46 -0400 Original-Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5] helo=snark.thyrsus.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JtIWX-0007FR-Uh for emacs-devel@gnu.org; Tue, 06 May 2008 04:27:46 -0400 Original-Received: by snark.thyrsus.com (Postfix, from userid 1000) id B7F679F054C; Tue, 6 May 2008 04:28:26 -0400 (EDT) Content-Disposition: inline In-Reply-To: <200805060114.m461EZ05007471@sallyv1.ics.uci.edu> X-Eric-Conspiracy: There is no conspiracy User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:96572 Archived-At: Dan Nicolaescu : > "Eric S. Raymond" writes: > > > 2. Otherwise, if you are in a vc dired buffer, and > > include-files-not-directories is non-nil, and no fileset is selected, > > select all files at and below directory level. > > This is a wart that is used by vc-next-action for the following: if in a > vc-dir buffer, you have a directory selected and do C-x v v what action > should be performed? > If you have files selected, the decision is made based on the files state. > For directories, then with this flag, return the list of files is > returned and the decision based on the file state. The VC action is > still performed on the directory... > Better ideas on how to handle this case are quite welcome. Hm. I think I see what you're driving at now. Here's what I think is right. We generalize vc-backend so it can take a directory argument, The default semantics is just: look for a backend by control subdirectory in the user's preference order. But if we select a backend on the directory using C-u C-x v v, it should remember that. Then we get rid of this wart. The directory is passed to commands; include-files-not-directories goes away. -- Eric S. Raymond