From: "Eric S. Raymond" <esr@thyrsus.com>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: "Eric S. Raymond" <esr@snark.thyrsus.com>, emacs-devel@gnu.org
Subject: Re: vc-directory breakage
Date: Mon, 5 May 2008 20:48:49 -0400 [thread overview]
Message-ID: <20080506004849.GA14523@thyrsus.com> (raw)
In-Reply-To: <200805060036.m460aVto021222@sallyv1.ics.uci.edu>
Dan Nicolaescu <dann@ics.uci.edu>:
> "Eric S. Raymond" <esr@thyrsus.com> writes:
>
> > To my knowledge, VC is not in a broken state now. Stefan fixed one of
> > the blocker bugs yesterday, probably while I was flat on my back and
> > hooked up to a heart monitor, and I got the other one this morning.
>
> There still are some issues. This:
>
> (defun vc-generic-status-printer (fileentry)
> (let* ((file (vc-dir-fileinfo->name fileentry))
> (backend (vc-responsible-backend file)))
> (vc-call-backend backend 'status-printer fileentry)))
>
> is not quite right.
> (vc-dir-fileinfo->name fileentry) is not an absolute file name, doing
> vc-responsible-backend on that is not going to work.
Ah. There's some Lisp function I need to wrap that arg in to make
it a full pathname, then; I've forgotten which it is, though. If you
remember before I do, feel free to fix it.
> Also please put the backend in a buffer-local variable in the vc-dir
> buffer, that way all the vc-responsible-backend calls in vc-generic-* can be
> eliminated.
> With that change this code will work.
> It does not work right now for at least hg, git and svn.
The recommended change may be a good idea, but I'm not sure. Those backend
checks are now being done at file granularity because some people were vocal
about support for mixing multiple VCSes in a directory. If we depended
on a per-directory buffer-local variable, that would get more difficult.
What is the actual failure you are seeing?
--
<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>
next prev parent reply other threads:[~2008-05-06 0:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 15:21 vc-directory breakage Eric S. Raymond
2008-05-05 15:32 ` David Kastrup
2008-05-05 15:39 ` Bastien Guerry
2008-05-05 15:45 ` David Kastrup
2008-05-05 15:52 ` Juanma Barranquero
2008-05-05 16:03 ` David Kastrup
2008-05-05 16:23 ` Bastien Guerry
2008-05-05 16:40 ` David Kastrup
2008-05-05 16:50 ` Lennart Borgman (gmail)
2008-05-05 17:00 ` Bastien Guerry
2008-05-05 20:14 ` Juanma Barranquero
2008-05-05 22:09 ` Thomas Lord
2008-05-05 22:17 ` Stephen J. Turnbull
2008-05-06 0:04 ` Eric S. Raymond
2008-05-06 0:36 ` Dan Nicolaescu
2008-05-06 0:48 ` Eric S. Raymond [this message]
2008-05-06 1:03 ` Stefan Monnier
2008-05-06 8:21 ` Eric S. Raymond
2008-05-06 9:08 ` David Kastrup
2008-05-06 16:34 ` Dan Nicolaescu
2008-05-07 1:30 ` Stefan Monnier
2008-05-06 1:10 ` Dan Nicolaescu
2008-05-06 9:01 ` Eric S. Raymond
2008-05-06 12:03 ` Dan Nicolaescu
2008-05-06 16:03 ` Eric S. Raymond
2008-05-06 6:36 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080506004849.GA14523@thyrsus.com \
--to=esr@thyrsus.com \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=esr@snark.thyrsus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).