From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: vc-directory breakage Date: Mon, 05 May 2008 17:36:31 -0700 Message-ID: <200805060036.m460aVto021222@sallyv1.ics.uci.edu> References: <20080505152149.E5BB99F054B@snark.thyrsus.com> <857ie8ahr3.fsf@lola.goethe.zz> <20080506000456.GA14206@thyrsus.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1210034250 17430 80.91.229.12 (6 May 2008 00:37:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 May 2008 00:37:30 +0000 (UTC) Cc: "Eric S. Raymond" , emacs-devel@gnu.org To: esr@thyrsus.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 06 02:38:05 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JtBBx-00027A-4h for ged-emacs-devel@m.gmane.org; Tue, 06 May 2008 02:38:01 +0200 Original-Received: from localhost ([127.0.0.1]:43006 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtBBF-0001bf-An for ged-emacs-devel@m.gmane.org; Mon, 05 May 2008 20:37:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JtBBB-0001az-BU for emacs-devel@gnu.org; Mon, 05 May 2008 20:37:13 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JtBB9-0001ab-Va for emacs-devel@gnu.org; Mon, 05 May 2008 20:37:12 -0400 Original-Received: from [199.232.76.173] (port=59981 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtBB9-0001aY-OG for emacs-devel@gnu.org; Mon, 05 May 2008 20:37:11 -0400 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1JtBB4-0006XE-Qn; Mon, 05 May 2008 20:37:07 -0400 X-ICS-MailScanner-Watermark: 1210638992.11769@w07TG6Ha6c6aRIjMU0nMAA Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m460aVto021222; Mon, 5 May 2008 17:36:31 -0700 (PDT) In-Reply-To: <20080506000456.GA14206@thyrsus.com> (Eric S. Raymond's message of "Mon, 5 May 2008 20:04:56 -0400") Original-Lines: 22 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:96550 Archived-At: "Eric S. Raymond" writes: > To my knowledge, VC is not in a broken state now. Stefan fixed one of > the blocker bugs yesterday, probably while I was flat on my back and > hooked up to a heart monitor, and I got the other one this morning. There still are some issues. This: (defun vc-generic-status-printer (fileentry) (let* ((file (vc-dir-fileinfo->name fileentry)) (backend (vc-responsible-backend file))) (vc-call-backend backend 'status-printer fileentry))) is not quite right. (vc-dir-fileinfo->name fileentry) is not an absolute file name, doing vc-responsible-backend on that is not going to work. Also please put the backend in a buffer-local variable in the vc-dir buffer, that way all the vc-responsible-backend calls in vc-generic-* can be eliminated. With that change this code will work. It does not work right now for at least hg, git and svn.