unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Drew Adams <drew.adams@oracle.com>, emacs-devel@gnu.org
Subject: Re: Bug with S-Tab in keymaps
Date: Mon, 5 May 2008 20:54:11 +0000	[thread overview]
Message-ID: <20080505205411.GB1365@muc.de> (raw)
In-Reply-To: <jwvzlr4mxqv.fsf-monnier+emacs@gnu.org>

Hi, Stefan!

On Mon, May 05, 2008 at 02:07:53PM -0400, Stefan Monnier wrote:
> > Should S-Tab be stored in a keymap as a symbol or a number?  Or are both
> > valid?  Which is the canonical form?  Where should the conversion from
> > the uncanonical form to the canonical be done?

> IIUC the canonical name of shift-tab in Emacs is `backtab'.
> The conversion from various other terminal-specific representations
> should be done in function-key-map.  If it's not done there, please
> report it as a bug.

That's what I thought I was doing.  I think the bug is that a symbol,
here 'S-tab, is being used when there's a perfectly good ASCII char +
bucky bit available.

I also think the canonical form of a key sequence should be defined in
the Elisp manual.  (Yes, I know, I'm implicitly volunteering to do
this.)

Icicles actually uses the symbol 'S-tab.  So, potentially, does a fair
bit of other software.

My own opinion, for what it's worth, is that read_key_sequence (in
keyboard.c) and lookup-key (in keymap.c) should both massage the
differences between #x2000009 and 'S-tab and 'S-TAB, somehow.  I suppose
even #x4000049 (&I + the control bucky bit) for the same thing is
conceivable.  Maybe `define-key' should canonicalise the key-sequences
it's given before writing them into a keymap.

In fact, `canonicalise-key-sequence' would be easy to write in Lisp, and
could be called from all of read_key_sequence, lookup-key and
define-key.  What do you think?

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).




  parent reply	other threads:[~2008-05-05 20:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-05 14:11 Bug with S-Tab in keymaps Alan Mackenzie
2008-05-05 18:07 ` Stefan Monnier
2008-05-05 20:40   ` Drew Adams
2008-05-06  0:46     ` Stefan Monnier
2008-05-05 20:54   ` Alan Mackenzie [this message]
2008-05-05 20:46     ` Lennart Borgman (gmail)
2008-05-05 21:00       ` Drew Adams
2008-05-06 21:26     ` Alan Mackenzie
2008-05-06 23:13       ` Miles Bader
2008-05-07  8:24         ` Alan Mackenzie
2008-05-07 15:17           ` Stefan Monnier
2008-05-06 17:08 ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080505205411.GB1365@muc.de \
    --to=acm@muc.de \
    --cc=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).