patch for vc-svn.el

patch for vc-svn.el

[Tom Tromey]

I tried vc-dir on an svn-controlled directory and got:

  file-name-absolute-p(nil)
  cd(nil)
  vc-svn-registered("ChangeLog")
  apply(vc-svn-registered "ChangeLog")
  vc-call-backend(SVN registered "ChangeLog")
  #[(b) "\302^H\303     #\205^T^@\304   \305^H#\205^T^@\306\307\310\"\207" [b f\
ile vc-call-backend registered vc-file-setprop vc-backend throw found t] 4](SVN\
)
  mapc(#[(b) "\302^H\303        #\205^T^@\304   \305^H#\205^T^@\306\307\310\"\2\
07" [b file vc-call-backend registered vc-file-setprop vc-backend throw found t\
] 4] (RCS CVS SVN SCCS Bzr Git Hg Mtn Arch MCVS))
  byte-code("\303^H\304\"^Y\305\306     \203^Q^@        \307=\203^U^@
\202^X^@
B\"\210)\310^H\304\307#\210\311\207" [file backend vc-handled-backends vc-file-\
getprop vc-backend mapc #[(b) "\302^H\303        #\205^T^@\304   \305^H#\205^T^\
@\306\307\310\"\207" [b file vc-call-backend registered vc-file-setprop vc-back\
end throw found t] 4] none vc-file-setprop nil] 4)
  vc-registered("ChangeLog")
  vc-backend("ChangeLog")
  vc-responsible-backend("ChangeLog")
[...]


This patch fixed it for me.

Tom

2008-05-04  Tom Tromey  <tromey@redhat.com>

        * vc-svn.el (vc-svn-registered): Don't pass nil to cd.

Index: vc-svn.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/vc-svn.el,v
retrieving revision 1.83
diff -u -c -r1.83 vc-svn.el
cvs diff: conflicting specifications of output style
*** vc-svn.el	2 May 2008 17:47:25 -0000	1.83
--- vc-svn.el	4 May 2008 23:51:28 -0000
***************
*** 121,127 ****
  						   "/entries")
  					   (file-name-directory file)))
      (with-temp-buffer
!       (cd (file-name-directory file))
        (let ((status
               (condition-case nil
                   ;; Ignore all errors.
--- 121,127 ----
  						   "/entries")
  					   (file-name-directory file)))
      (with-temp-buffer
!       (cd (or (file-name-directory file) default-directory))
        (let ((status
               (condition-case nil
                   ;; Ignore all errors.

Re: patch for vc-svn.el

[Dan Nicolaescu]

Tom Tromey <tromey@redhat.com> writes:

  > I tried vc-dir on an svn-controlled directory and got:
  > 
  >   file-name-absolute-p(nil)
  >   cd(nil)
  >   vc-svn-registered("ChangeLog")

This is not right, this function should only be called with an absolute
file name.

  >   apply(vc-svn-registered "ChangeLog")
  >   vc-call-backend(SVN registered "ChangeLog")
  >   #[(b) "\302^H\303     #\205^T^@\304   \305^H#\205^T^@\306\307\310\"\207" [b f\
  > ile vc-call-backend registered vc-file-setprop vc-backend throw found t] 4](SVN\
  > )
  >   mapc(#[(b) "\302^H\303        #\205^T^@\304   \305^H#\205^T^@\306\307\310\"\2\
  > 07" [b file vc-call-backend registered vc-file-setprop vc-backend throw found t\
  > ] 4] (RCS CVS SVN SCCS Bzr Git Hg Mtn Arch MCVS))
  >   byte-code("\303^H\304\"^Y\305\306     \203^Q^@        \307=\203^U^@
  > \202^X^@
  > B\"\210)\310^H\304\307#\210\311\207" [file backend vc-handled-backends vc-file-\
  > getprop vc-backend mapc #[(b) "\302^H\303        #\205^T^@\304   \305^H#\205^T^\
  > @\306\307\310\"\207" [b file vc-call-backend registered vc-file-setprop vc-back\
  > end throw found t] 4] none vc-file-setprop nil] 4)
  >   vc-registered("ChangeLog")
  >   vc-backend("ChangeLog")
  >   vc-responsible-backend("ChangeLog")
  > [...]

Can you show here?  This should show the culprit.
I only have a few days old checkout, where all these things work just
fine, so something went wrong with the latest experiments with vc*el ...

Re: patch for vc-svn.el

[Dan Nicolaescu]

Tom Tromey <tromey@redhat.com> writes:

  > I tried vc-dir on an svn-controlled directory and got:
  > 
  >   file-name-absolute-p(nil)
  >   cd(nil)
  >   vc-svn-registered("ChangeLog")
  >   apply(vc-svn-registered "ChangeLog")

This is due to ESR's changes, stay with a version before May 1st until
he gets a chance to fix things up.