From: Alan Mackenzie <acm@muc.de>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: martin rudalics <rudalics@gmx.at>,
Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel@gnu.org
Subject: Re: Emacs 22.2 release plans - request for a slight delay.
Date: Thu, 6 Mar 2008 22:38:57 +0000 [thread overview]
Message-ID: <20080306223857.GC3049@muc.de> (raw)
In-Reply-To: <87ir01krr7.fsf@stupidchicken.com>
Hi, Yidong,
It's me again, causing trouble. ;-(
On Wed, Mar 05, 2008 at 12:25:16PM -0500, Chong Yidong wrote:
> Hi,
> As a reminder, I'll be rolling the 22.1.92 pretest on Friday. If any
> of you need to delay the pretest for whatever reason, please send an
> email.
I'm asking for a slight delay (perhaps over the weekend?) to fix a
serious bug in C mode, namely:
Subject: Re: Unbearably slow editing in .h files
From: martin rudalics <rudalics@gmx.at> (and Stefan)
Date: Sat, 23 Feb 2008 23:51:34 +0100
Message-ID: <47C0A376.8080105@gmx.at>
Visit lisp.h, go to the end of the buffer, and do
M-x RET c-beginning-of-defun RET
This is horrendously slow (~30 seconds).
I've just had a look at c-beginning-of-defun, and I've narrowed the
fault down to `c-in-knr-argdecl', where the code laboriously trundles
back one paren pair at a time until it finds a "}" (or BOB). This is
clearly suboptimal in a region with several hundred consecutive
declarations without brace-blocks. There are ~900 consecutive
paren-pairs in the tail of lisp.h.
Even worse, c-in-knr-argdecl gets called twice, doubling the pain.
Just how many paren/bracket pairs can there be in the K&R region of the
header of a C function? There is no absolute limit, but such a region
will typically look less extravagant than this:
int foo (bar, baz, yuk)
int bar [] ;
int (*baz) (my_type) ;
int (*) (void) (*yuk) (void) ;
{
, which has 7 such pairs. So perhaps if I put the limit at 32, this
will be safe for any function not appearing in the Obfuscated C
competition or deliberately written to break editors. :-)
This will probably be a "quick and easy" change, taking, perhaps, an
hour. However, it's probably worth while doing it calmly and carefully.
;-)
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2008-03-06 22:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 19:53 Emacs 22.2 release plans Chong Yidong
2008-03-05 17:25 ` Chong Yidong
2008-03-05 23:58 ` Kim F. Storm
2008-03-06 0:38 ` Glenn Morris
2008-03-06 11:19 ` Kim F. Storm
2008-03-06 15:16 ` Dan Nicolaescu
2008-03-06 15:51 ` Jason Rumney
2008-03-06 16:12 ` Dan Nicolaescu
2008-03-06 17:32 ` Stefan Monnier
2008-03-06 17:31 ` Stefan Monnier
2008-03-06 18:56 ` Chong Yidong
2008-03-07 10:55 ` Kim F. Storm
2008-03-06 22:38 ` Alan Mackenzie [this message]
2008-03-06 23:19 ` Emacs 22.2 release plans - request for a slight delay Chong Yidong
2008-03-07 7:25 ` Alan Mackenzie
2008-03-07 16:17 ` Chong Yidong
2008-03-07 23:15 ` Alan Mackenzie
2008-03-07 23:04 ` Chong Yidong
2008-03-07 23:33 ` Nick Roberts
2008-03-07 23:24 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080306223857.GC3049@muc.de \
--to=acm@muc.de \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).