From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: lisp-indent-line and comment-region in emacs-lisp-mode menu Date: Wed, 05 Mar 2008 11:00:13 -0800 Message-ID: <200803051900.m25J0Eni011450@sallyv1.ics.uci.edu> References: <200803042223.m24MNxAA001171@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204743930 32671 80.91.229.12 (5 Mar 2008 19:05:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 5 Mar 2008 19:05:30 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 05 20:05:54 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JWytG-000886-8V for ged-emacs-devel@m.gmane.org; Wed, 05 Mar 2008 20:02:58 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JWysj-0006Nl-10 for ged-emacs-devel@m.gmane.org; Wed, 05 Mar 2008 14:02:25 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JWysf-0006NO-Al for emacs-devel@gnu.org; Wed, 05 Mar 2008 14:02:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JWysd-0006N8-PG for emacs-devel@gnu.org; Wed, 05 Mar 2008 14:02:21 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JWysd-0006N5-MF for emacs-devel@gnu.org; Wed, 05 Mar 2008 14:02:19 -0500 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1JWysd-0007a1-3F for emacs-devel@gnu.org; Wed, 05 Mar 2008 14:02:19 -0500 X-ICS-MailScanner-Watermark: 1205348416.88408@Lgk87ewUltoby8UNSdrZtw Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m25J0Eni011450; Wed, 5 Mar 2008 11:00:14 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Wed, 05 Mar 2008 13:41:55 -0500") Original-Lines: 38 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:91403 Archived-At: Stefan Monnier writes: > > Wouldn't it be better if the emacs-lisp-mode menu used > > indent-for-tab-command instead of lisp-indent-line and > > comment-dwim instead of comment-region ? > > For indent-line, it might be OK, although it suffers from the problem > that indent-for-tab-command doesn't necessarily indent the current line. Them maybe the solution is not to have a menu called "Indent Line". If we don't provide a key binding for such a thing, then we shouldn't bother with a menu binding for it. What would be a better name for the menu entry? > For comment-region, the problem is worse because as long as > transient-mark-mode is off, comment-dwim does not do comment-region. Would making the menu depend on transient-mark-mode be an option? Any better ideas? > Those DWIMish bindings (TAB, M-;) are problematic in this situation > because the menu entry text cannot faithfully describe the behavior. > > The former don't have key bindings, but the latter do, so the menus > > do not help users learn the key bindings. > > Indeed. > > > What about "Indent region"? Currently TAB does when > > transient-mark-mode is on... > > So are you suggesting to put TAB on both "indent line" and "indent > region"? That might be a good idea for the transient-mark-mode: show the users that the only key binding they need to know for indenting is TAB.