unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Andreas Schwab <schwab@suse.de>, emacs-devel@gnu.org
Subject: Re: easy-menu subtlety
Date: Wed, 20 Feb 2008 10:20:40 -0800	[thread overview]
Message-ID: <200802201820.m1KIKfoA012850@sallyv1.ics.uci.edu> (raw)
In-Reply-To: <jwv4pc3ld81.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 20 Feb 2008 13:02:06 -0500")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

  > >> > The last 3 lines of this code sequence in lisp/progmodes/verilog-mode.el:
  > >> >
  > >> >     ("Move"
  > >> >      ,(if (featurep 'xemacs)
  > >> >           (progn 
  > >> >             ["Beginning of function"            verilog-beg-of-defun t]
  > >> >             ["End of function"                  verilog-end-of-defun t]
  > >> >             ["Mark function"                    verilog-mark-defun t])
  > >> >         ["Beginning of function"                beginning-of-defun t]
  > >> >         ["End of function"                      end-of-defun t]
  > >> >         ["Mark function"                        mark-defun t])
  > >> 
  > >> That looks completely bogus to me.  The result of the evaluation of the
  > >> form is a single vector, with the other two just thrown away.  I think
  > >> the intention was to write this:
  > >> 
  > >> ("Move"
  > >> ,@(if (featurep 'xemacs)
  > >> '(["Beginning of function"		verilog-beg-of-defun t]
  > >> ["End of function"			verilog-end-of-defun t]
  > >> ["Mark function"			verilog-mark-defun t])
  > >> '(["Beginning of function"		beginning-of-defun t]
  > >> ["End of function"			end-of-defun t]
  > >> ["Mark function"			mark-defun t]))
  > 
  > > Thanks, but it doesn't work with emacs-21: "Invalid menu item in easymenu"
  > 
  > I don't see any good reason for it not to work.  Most likely it's some
  > silly detail somewhere.  This said, I'd recommend you just remove the
  > test and use the XEmacs side of the code, and make sure that
  > verilog-beg-of-defun is always defined (and make it an alias to
  > beginning-of-defun under Emacs).

The only problem with that is that C-M-a and C-M-e won't appear in the
"Beginning of function" and "End of function" menu entries.  They would
appear if the explicit C-M-a and C-M-e bindings for
verilog-beg-of-defun/verilog-end-of-defun are also enabled for emacs.
But that is ugly... 




  reply	other threads:[~2008-02-20 18:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20 16:01 easy-menu subtlety Dan Nicolaescu
2008-02-20 16:32 ` Andreas Schwab
2008-02-20 17:20   ` Dan Nicolaescu
2008-02-20 18:02     ` Stefan Monnier
2008-02-20 18:20       ` Dan Nicolaescu [this message]
2008-02-20 19:17         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802201820.m1KIKfoA012850@sallyv1.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).