From: Dan Nicolaescu <dann@ics.uci.edu>
To: Glenn Morris <rgm@gnu.org>
Cc: Tom Tromey <tromey@redhat.com>,
"Eric S. Raymond" <esr@snark.thyrsus.com>,
emacs-devel@gnu.org
Subject: Re: State of VC?
Date: Wed, 23 Jan 2008 23:07:19 -0800 [thread overview]
Message-ID: <200801240707.m0O77KcX018757@sallyv1.ics.uci.edu> (raw)
In-Reply-To: <yjlk6h4hv1.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 22 Jan 2008 17:26:26 -0500")
Glenn Morris <rgm@gnu.org> writes:
> Dan Nicolaescu wrote:
>
> > Pointers?
> > I only remember one bug:
> > http://permalink.gmane.org/gmane.emacs.devel/87064
>
> Links to VC-related issues that are unaddressed AFAIK. Some of them
> may well be dealt with - you will know better than I.
>
>
> strange window behavior from vc-diff
> http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01276.html
The problem here is indeed in vc-diff-sentinel. It calls
(shrink-window-if-larger-than-buffer)
which does this:
(when (null window)
(setq window (selected-window)))
So it will look at (selected-window), so it will shrink the wrong
window...
Not sure what the best solution is here.
> vc-dired refresh
> http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01268.html
This is for vc-dired. Needs to be looked checked if it still happens
when vc-dired is replaced with vc-status.
> Patch: vc-dired-hook -vs- vc-call
> http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg00549.html
>
> Further VC tuning is blocked
> http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg00410.html
Already replied about these in another message.
> strange byte compiler behavior
> http://lists.gnu.org/archive/html/emacs-devel/2007-12/msg01356.html
>
> vc.el complaint about reference to free variable `file'
> http://lists.gnu.org/archive/html/emacs-devel/2007-12/msg00872.html
Still need fixing.
> wrong behaviour of vc-workfile-unchanged-p
> http://lists.gnu.org/archive/html/emacs-devel/2007-12/msg00867.html
The analysis in the bug report seems correct.
Opinions on this patch?
(this code has been around for a long time...)
--- vc-hooks.el.~1.220.~2008-01-13 10:45:01.000000000 -0800
+++ vc-hooks.el2008-01-23 23:01:02.000000000 -0800
@@ -558,10 +558,11 @@
(if (and checkout-time
;; Tramp and Ange-FTP return this when they don't know the time.
(not (equal lastmod '(0 0))))
- (equal checkout-time lastmod)
- (let ((unchanged (vc-call workfile-unchanged-p file)))
- (vc-file-setprop file 'vc-checkout-time (if unchanged lastmod 0))
- unchanged))))
+ (if (equal checkout-time lastmod)
+ t
+ (let ((unchanged (vc-call workfile-unchanged-p file)))
+ (vc-file-setprop file 'vc-checkout-time (if unchanged lastmod 0))
+ unchanged)))))
(defun vc-default-workfile-unchanged-p (backend file)
"Check if FILE is unchanged by diffing against the master version.
> [chet.wood@sun.com: vc-sccs-workfile-version returns wrong version number]
> http://lists.gnu.org/archive/html/emacs-devel/2007-11/msg01572.html
No idea.
next prev parent reply other threads:[~2008-01-24 7:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 16:43 State of VC? Eric S. Raymond
2008-01-22 17:08 ` Tom Tromey
2008-01-22 22:07 ` Dan Nicolaescu
2008-01-22 21:51 ` Tom Tromey
2008-01-23 2:31 ` Stefan Monnier
2008-01-23 19:01 ` Dan Nicolaescu
2008-01-25 0:17 ` Tom Tromey
2008-01-26 19:21 ` Dan Nicolaescu
2008-01-26 22:06 ` Eric S. Raymond
2008-02-17 18:16 ` Dan Nicolaescu
2008-02-17 18:24 ` Thien-Thi Nguyen
2008-02-17 18:56 ` Dan Nicolaescu
2008-02-18 8:03 ` Thien-Thi Nguyen
2008-02-18 8:36 ` Miles Bader
2008-02-18 8:48 ` Thien-Thi Nguyen
2008-02-18 8:57 ` Miles Bader
2008-02-18 9:18 ` Thien-Thi Nguyen
2008-02-25 15:14 ` Thien-Thi Nguyen
2008-02-18 17:40 ` Dan Nicolaescu
2008-02-19 13:52 ` Thien-Thi Nguyen
2008-02-19 15:44 ` Dan Nicolaescu
2008-02-19 16:57 ` Thien-Thi Nguyen
2008-02-19 20:53 ` Dan Nicolaescu
2008-02-17 23:09 ` Eric S. Raymond
2008-01-22 22:26 ` Glenn Morris
2008-01-23 13:01 ` Johan Bockgård
2008-01-24 7:07 ` Dan Nicolaescu [this message]
2008-01-24 8:58 ` Thien-Thi Nguyen
2008-01-24 14:57 ` Stefan Monnier
2008-01-24 15:09 ` Thien-Thi Nguyen
2008-01-25 22:47 ` Richard Stallman
2008-01-26 2:57 ` Stefan Monnier
2008-01-26 7:46 ` Alexandru Harsanyi
2008-01-24 13:23 ` Thien-Thi Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801240707.m0O77KcX018757@sallyv1.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=esr@snark.thyrsus.com \
--cc=rgm@gnu.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).