From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: State of VC? Date: Wed, 23 Jan 2008 11:01:00 -0800 Message-ID: <200801231901.m0NJ10CP029274@sallyv1.ics.uci.edu> References: <20080122164306.3B33C83045C@snark.thyrsus.com> <200801222207.m0MM7rlR014153@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1201115064 14907 80.91.229.12 (23 Jan 2008 19:04:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Jan 2008 19:04:24 +0000 (UTC) Cc: "Eric S. Raymond" , emacs-devel@gnu.org To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 23 20:04:43 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JHktu-00034l-6R for ged-emacs-devel@m.gmane.org; Wed, 23 Jan 2008 20:04:42 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHktU-0006zO-Ci for ged-emacs-devel@m.gmane.org; Wed, 23 Jan 2008 14:04:16 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHksZ-0006cy-1m for emacs-devel@gnu.org; Wed, 23 Jan 2008 14:03:19 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHksX-0006bQ-6b for emacs-devel@gnu.org; Wed, 23 Jan 2008 14:03:18 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHksX-0006bA-0w for emacs-devel@gnu.org; Wed, 23 Jan 2008 14:03:17 -0500 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1JHksW-0004zM-H7 for emacs-devel@gnu.org; Wed, 23 Jan 2008 14:03:16 -0500 X-ICS-MailScanner-Watermark: 1201719662.89314@3Atrn/b5A2TldJPTZxMO6w Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m0NJ10CP029274; Wed, 23 Jan 2008 11:01:00 -0800 (PST) In-Reply-To: (Tom Tromey's message of "Tue, 22 Jan 2008 14:51:05 -0700") Original-Lines: 69 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_SV 0.08) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87386 Archived-At: Tom Tromey writes: > Tom> There are a few bug reports, some with patches, that were never looked > Tom> at. Reviewing those would be a good start. > > Dan> Pointers? > Dan> I only remember one bug: > Dan> http://permalink.gmane.org/gmane.emacs.devel/87064 > > http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg00549.html > (this patch is probably bogus) Does this still happen? This might have been due to bugs due to the introduction of the ignored and unregistered states. > http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg00267.html This should have been fixed by a different patch. > http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg00410.html > (a patch, not really a bug) Don't know about this one. If you think is correct and you tested it, I can check it in. Although I hope you get commit access soon. > I also reported one about use of shrink-window-if-larger-than-buffer > and VC, but I don't see it right now. Glenn posted a link to that one. > Dan> By this time I think that we can declare the vc-status experiment a > Dan> success. It is in decent shape and the code is still very simple and > Dan> understandable. Do you agree? > > I think it has potential, but it is not ready. Sure it's not. The point here is just to move it from the "experimental, can be deleted anytime" state to "work in progress, this is the future" so that more people can work on this. > Tom> * Make dir-status back end function update the vc-status buffer > Tom> asynchronously. This means using a process filter. > > Dan> I am not yet convinced that we should do this. The discussion on this > Dan> was started by your observation that PCL-CVS and psvn "pause" when > Dan> updating the display. It would be good to actually investigate and see > Dan> what the cause of the "pause" is, and make sure that it can be fixed by > Dan> going asynchronous. > > According to the psvn maintainer it is due to sorting the entries > after svn exits. > > Anyway the experiment is pretty easy. I will try to remember to do it. OK, thanks. > Tom> * Don't clear vc-status buffer when updating. This means figuring out > Tom> how to insert new items into the ewoc at the right point. > > Dan> We don't need to do this right away an easy stopgap: we can keep a list > Dan> of selected items and select them at the time they are inserted. > > This is not the same if a marked file changes from modified to unmodified. > In this case it will disappear from the listing. > > IMO it is nicer UI for the entries to persist a bit. OK. Would this need a change in the interface to the backend?