unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Andreas Röhler" <andreas.roehler@online.de>
To: emacs-devel@gnu.org
Cc: Richard Stallman <rms@gnu.org>,
	Reiner Steib <reinersteib+gmane@imap.cc>,
	Juri Linkov <juri@jurta.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	Stephen Turnbull <stephen@xemacs.org>,
	Miles Bader <miles@gnu.org>
Subject: Re: region-active-p
Date: Tue, 11 Dec 2007 12:52:25 +0100	[thread overview]
Message-ID: <200712111252.26116.andreas.roehler@online.de> (raw)
In-Reply-To: <87odcxpmy9.fsf@jurta.org>

Am Dienstag, 11. Dezember 2007 10:57 schrieb Juri Linkov:
> >> I came up with a better solution to the question of what region-active-p
> >> should do when the region is empty: make it a user option.
> >> I think that will make people happy, because I expect most users will
> >> have the same preference for all the commands.
> >>
> >> I will install it when I have a good connection.
> >
> > That certainly wouldn't be wrong on the logical level,
> > however can't help in original case, reduces
> > compatibilty rather than enhances them.
> >
> > My idea was to make the writing of compatible code a
> > little bit easier, to get rid of one of these (featurep
> > 'xemacs) forms occasionally.
> >
> > If you could ask Juri to install his answer we will all
> > live in a better world. :)
>
> I proposed:
>
> (defun region-active-p ()
>     (and transient-mark-mode mark-active
> 	 (not (eq (region-beginning) (region-end)))))
>
> And as I understand, Richard wants:
>
> (defun region-active-p ()
>     (and transient-mark-mode mark-active
> 	 (if some-new-user-option
>              (not (eq (region-beginning) (region-end))))))
>
> This seems like a good solution.


That new design of `region-active-p' would permit
behaving as `region-exists-p',

the result therefor will not be comparable with XEmacs,
even if it will differ only on a mince level. GNU user
then is able to allow something, which in not allowed
in XE, where to be `active' region _must_ have an
extend.

But why introduce new diffs? If there is a need I will
change my mind.

Until then I see two practical cases: 

- a region with an extend is needed
- if mark is set it's sufficient

Both questions are served already. For case two
`mark-active' or `region-exists-p' are enough, case one
is perfect answered with `region-active-p' in it's
comparable variant.

BTW if something deserves a `new-user-option' here, IMO
it's `transient-mark-mode', because to permit highlighting or not
has not really a meaning about the existence of the
region.

Then I come to this

(defun region-active-p ()
  (if user-requires-transient-mark-mode
      (and transient-mark-mode mark-active
	   (not (eq (region-beginning) (region-end))))
    (not (eq (region-beginning) (region-end)))))


Andreas Röhler

  reply	other threads:[~2007-12-11 11:52 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-19  9:49 region-active-p Andreas Röhler
2007-10-19 20:57 ` region-active-p Juri Linkov
2007-10-21  7:25   ` region-active-p Richard Stallman
2007-10-21 13:56     ` region-active-p Stefan Monnier
2007-10-21 14:48       ` region-active-p Miles Bader
2007-10-21 19:22         ` region-active-p Andreas Röhler
2007-10-23  7:12           ` region-active-p Richard Stallman
2007-10-23  8:53             ` region-active-p Andreas Röhler
2007-10-23 17:53               ` region-active-p Richard Stallman
2007-10-24  7:33                 ` region-active-p Andreas Röhler
2007-10-25  2:10                   ` region-active-p Richard Stallman
2007-10-24 19:34             ` region-active-p Stephen J. Turnbull
2007-10-25  9:01               ` region-active-p Richard Stallman
2007-10-26  5:38                 ` region-active-p Stephen J. Turnbull
2007-10-26  8:17                   ` region-active-p Andreas Röhler
2007-10-26  9:21                     ` region-active-p Stephen J. Turnbull
2007-10-26 11:03                       ` region-active-p Andreas Röhler
2007-10-26 21:53                         ` region-active-p Stephen J. Turnbull
2007-10-27  2:28                       ` region-active-p Richard Stallman
2007-10-27  5:20                         ` region-active-p Stephen J. Turnbull
2007-10-27  6:17                           ` region-active-p Miles Bader
2007-10-27  7:57                             ` region-active-p Andreas Röhler
2007-10-28  6:55                             ` region-active-p Stephen J. Turnbull
2007-10-28  7:32                               ` region-active-p Miles Bader
2007-10-28 12:15                             ` region-active-p Johan Bockgård
2007-10-28 21:07                               ` region-active-p Stefan Monnier
2007-10-28 21:07                               ` region-active-p Stefan Monnier
2007-10-27 23:41                           ` region-active-p Richard Stallman
2007-10-28  1:21                             ` region-active-p Stefan Monnier
2007-10-28  1:27                               ` region-active-p Miles Bader
2007-10-28  2:43                                 ` region-active-p Stefan Monnier
2007-10-29  0:11                               ` region-active-p Richard Stallman
2007-10-29  1:40                                 ` region-active-p Stefan Monnier
2007-12-10 23:08                                   ` region-active-p Richard Stallman
2007-12-11  8:15                                     ` region-active-p Andreas Röhler
2007-12-11  9:57                                       ` region-active-p Juri Linkov
2007-12-11 11:52                                         ` Andreas Röhler [this message]
2007-12-11 14:55                                           ` region-active-p Stefan Monnier
2007-12-11 17:05                                             ` region-active-p Andreas Röhler
2007-12-11 18:16                                               ` region-active-p Stefan Monnier
2007-12-11  9:07                                     ` region-active-p Andreas Röhler
2007-12-11  9:59                                       ` region-active-p Juri Linkov
2007-12-11 11:50                                         ` region-active-p Andreas Röhler
2007-10-28  7:29                             ` region-active-p Stephen J. Turnbull
2007-10-28 21:06                               ` region-active-p Stefan Monnier
2007-10-29  0:11                               ` region-active-p Richard Stallman
2007-10-30  0:12                                 ` region-active-p Stephen J. Turnbull
2007-10-30  8:22                                   ` region-active-p Richard Stallman
2007-10-30  8:59                                     ` region-active-p David Kastrup
2007-10-31  7:46                                       ` region-active-p Richard Stallman
2007-10-30 15:03                                     ` region-active-p Drew Adams
2007-10-30 19:03                                       ` region-active-p Stefan Monnier
2007-10-30 19:49                                         ` region-active-p Drew Adams
2007-10-30 20:15                                           ` region-active-p Stefan Monnier
2007-10-30 20:28                                             ` region-active-p Drew Adams
2007-10-30 21:30                                               ` region-active-p Stefan Monnier
2007-10-30 23:43                                           ` region-active-p Miles Bader
2007-10-31  6:35                                             ` region-active-p David Kastrup
2007-10-31  7:59                                               ` region-active-p Miles Bader
2007-11-03 21:08                                             ` region-active-p Stephen J. Turnbull
2007-10-31  7:47                                       ` region-active-p Richard Stallman
2007-10-31  7:47                                       ` region-active-p Richard Stallman
2007-10-31  8:00                                         ` region-active-p Miles Bader
2007-10-31 23:58                                           ` region-active-p Richard Stallman
2007-11-01  2:33                                             ` region-active-p Miles Bader
2007-11-01  2:55                                               ` region-active-p Stefan Monnier
2007-11-01 10:06                                                 ` region-active-p Kim F. Storm
2007-11-01 15:46                                                   ` region-active-p Drew Adams
2007-11-01 17:56                                                     ` region-active-p David Kastrup
2007-11-01 23:08                                                       ` region-active-p Richard Stallman
2007-11-01 19:04                                               ` region-active-p Richard Stallman
2007-11-02  0:18                                                 ` region-active-p Miles Bader
2007-11-02 15:02                                                   ` region-active-p Richard Stallman
2007-11-02 21:39                                                     ` region-active-p Stefan Monnier
2007-11-02 22:31                                                     ` region-active-p Miles Bader
2007-11-03 20:48                                                       ` region-active-p Richard Stallman
2007-11-05  6:48                                                         ` region-active-p Miles Bader
2007-10-29  8:24                               ` region-active-p Andreas Röhler
2007-10-22  6:09         ` region-active-p Andreas Röhler
2007-10-21 17:18       ` region-active-p Stephen J. Turnbull
2007-10-21 20:54         ` region-active-p Reiner Steib

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712111252.26116.andreas.roehler@online.de \
    --to=andreas.roehler@online.de \
    --cc=emacs-devel@gnu.org \
    --cc=juri@jurta.org \
    --cc=miles@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=reinersteib+gmane@imap.cc \
    --cc=rms@gnu.org \
    --cc=stephen@xemacs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).