From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: verilog-mode.el for inclusion in Emacs 22.2 Date: Sat, 08 Dec 2007 11:40:21 -0800 Message-ID: <200712081940.lB8JeTqn017288@oogie-boogie.ics.uci.edu> References: <17901.71.243.124.123.1197048267.squirrel@svaha.dyndns.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1197143009 857 80.91.229.12 (8 Dec 2007 19:43:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Dec 2007 19:43:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Wilson Snyder" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 08 20:43:39 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J15aL-0001e1-TP for ged-emacs-devel@m.gmane.org; Sat, 08 Dec 2007 20:43:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J15a4-00077R-KQ for ged-emacs-devel@m.gmane.org; Sat, 08 Dec 2007 14:43:20 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J15a1-00075y-UA for emacs-devel@gnu.org; Sat, 08 Dec 2007 14:43:17 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J15a0-000748-9t for emacs-devel@gnu.org; Sat, 08 Dec 2007 14:43:17 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J15a0-00073k-4L for emacs-devel@gnu.org; Sat, 08 Dec 2007 14:43:16 -0500 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J15Zz-0003QA-IJ for emacs-devel@gnu.org; Sat, 08 Dec 2007 14:43:15 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id lB8JeTqn017288; Sat, 8 Dec 2007 11:40:37 -0800 (PST) In-Reply-To: <17901.71.243.124.123.1197048267.squirrel@svaha.dyndns.org> (Wilson Snyder's message of "Fri, 7 Dec 2007 12:24:27 -0500 (EST)") Original-Lines: 30 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84889 Archived-At: Thank you for your contribution. I have checked it in. I have also done some cleanups to reduce the number of byte compile warnings. These warnings: In verilog-read-sub-decls-sig: verilog-mode.el:6294:65:Warning: attempt to inline `verilog-modi-get-inouts' before it was defined verilog-mode.el:6294:65:Warning: attempt to inline `verilog-modi-get-outputs' before it was defined verilog-mode.el:6294:65:Warning: attempt to inline `verilog-modi-get-inputs' before it was defined verilog-mode.el:6294:65:Warning: attempt to inline `verilog-modi-get-inouts' before it was defined verilog-mode.el:6294:65:Warning: attempt to inline `verilog-modi-get-outputs' before it was defined verilog-mode.el:6294:65:Warning: attempt to inline `verilog-modi-get-inputs' before it was defined should be very easy to fix, but it wasn't immediately obvious to me how to move the code around to make them go away. Can you please do this? What versions of emacs do you want to support? Depending on that some more cleanups can be done and we might be able to delete unneeded compatibility code. Thanks --dan