unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: emacs-devel@gnu.org
Subject: Re: vc commit clears undo history
Date: Mon, 03 Dec 2007 13:26:14 -0800	[thread overview]
Message-ID: <200712032126.lB3LQEVV003498@oogie-boogie.ics.uci.edu> (raw)
In-Reply-To: <47546BBB.1060605@gnu.org> (Sam Steingold's message of "Mon, 03 Dec 2007 15:48:59 -0500")

Sam Steingold <sds@gnu.org> writes:

  > David Kastrup wrote:
  > > "Sam Steingold" <ssteingold@janestcapital.com> writes:
  > > 
  > >> GNU Emacs 23.0.50.29 (x86_64-unknown-linux-gnu, GTK+ Version 2.8.20)
  > >>  of 2007-12-03 on nyc-qws-005
  > >>  '-with-gtk' '-with-gif=no'
  > >>
  > >> a long-standing bug (bad feature?) is that when a file is committed
  > >> using vc (C-x v v) or pcvs (c in *cvs* buffer), it buffer's undo history
  > >> is discarder.

I have a patch that tries to avoid discarding the undo by looking at the
md5 checksum of the buffer contents and the file on disk. But I am not
100% confident that it is entirely correct....

  > > I think the rationale for that might be that in order to have the files
  > > identifiable as unmodified, some version control systems might do a
  > > recheckout on them, and replace strings like $Id: whatever$ with
  > > different information.  In any case, a revert-buffer is done on the file
  > > after checking it in, I believe.
  > > 
  > > It might not be easy to get consistent undo information in this case.
  > 
  > fwiw, "other vc interfaces", such as dvc (which interfaces to
  > distributed VCs (haz/hg/git &c), do not discard the undo information
  > after a commit.

How does it deal with the case when the file contains keywords that are
expanded on commit?
BTW VC interfaces with distributed VCs just fine.

      reply	other threads:[~2007-12-03 21:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-03 20:07 vc commit clears undo history Sam Steingold
2007-12-03 20:26 ` David Kastrup
2007-12-03 20:48   ` Sam Steingold
2007-12-03 21:26     ` Dan Nicolaescu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712032126.lB3LQEVV003498@oogie-boogie.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).