From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Bogus byte-compiler warnings Date: Sat, 01 Dec 2007 08:47:29 -0800 Message-ID: <200712011647.lB1GlXh4018555@oogie-boogie.ics.uci.edu> References: <87zmar47tm.fsf@cyd.mit.edu> <87mz6nfos7.fsf@furball.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1196527728 11798 80.91.229.12 (1 Dec 2007 16:48:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 1 Dec 2007 16:48:48 +0000 (UTC) Cc: Richard Stallman , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 01 17:48:56 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IyVWQ-0003r3-P6 for ged-emacs-devel@m.gmane.org; Sat, 01 Dec 2007 17:48:55 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IyVWA-00033B-Ri for ged-emacs-devel@m.gmane.org; Sat, 01 Dec 2007 11:48:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IyVW6-0002yI-0d for emacs-devel@gnu.org; Sat, 01 Dec 2007 11:48:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IyVW2-0002rl-VM for emacs-devel@gnu.org; Sat, 01 Dec 2007 11:48:33 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IyVW2-0002ra-Ro for emacs-devel@gnu.org; Sat, 01 Dec 2007 11:48:30 -0500 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IyVVw-0003RF-9N; Sat, 01 Dec 2007 11:48:24 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id lB1GlXh4018555; Sat, 1 Dec 2007 08:47:33 -0800 (PST) In-Reply-To: (Reiner Steib's message of "Sat, 01 Dec 2007 12:29:27 +0100") Original-Lines: 33 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84428 Archived-At: Reiner Steib writes: > On Sun, Nov 19 2006, Chong Yidong wrote: > =A0 ^^^^^^^^^^^ >=20 > [ See for the > complete thread. ] >=20 > > Richard Stallman writes: > > > >> > The reason there is a warning for foo-1 is that the code in the > >> > compiler to avoid such warnings recognizes only the simpler ca= se (such > >> > as foo-2) and not the more complex case that foo-1 is. > >> > > >> > I would not mind if that code were made smarter. > >> > >> How bout this patch? > >> > >> I think it would be better to save this for after the release. > >> Changes in this code are somewhat risky, and even if you have > >> been rather careful, you could easily break something. > > > > I had already checked it into CVS (since you put it in FOR-RELEASE, I > > assumed you wanted it fixed). But I agree that now is not the time > > for such changes, so I've reverted the change. >=20 > The patch below has been reverted because Richard didn't want to > install it before the release of Emacs 22.1. Maybe it should be > installed now in the trunk? The example given at the start of this thread does not produce any warning now (I fixed it on 2007-11-10). So unless there are other cases that produce bogus warnings, this patch should not be needed anymore.