From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: [patch] vc-git-dired-state-info buglet Date: Wed, 28 Nov 2007 23:22:03 -0800 Message-ID: <200711290722.lAT7M7L4017604@oogie-boogie.ics.uci.edu> References: <87tzndw4cu.fsf@ambire.localdomain> <87ir3nl5fp.fsf@wine.dyndns.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1196321067 24148 80.91.229.12 (29 Nov 2007 07:24:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 29 Nov 2007 07:24:27 +0000 (UTC) Cc: Thien-Thi Nguyen , emacs-devel@gnu.org To: Alexandre Julliard Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 29 08:24:35 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IxdlB-0005MT-O3 for ged-emacs-devel@m.gmane.org; Thu, 29 Nov 2007 08:24:33 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ixdkw-0008ON-56 for ged-emacs-devel@m.gmane.org; Thu, 29 Nov 2007 02:24:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ixdkt-0008OI-3c for emacs-devel@gnu.org; Thu, 29 Nov 2007 02:24:15 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ixdkq-0008O6-Kv for emacs-devel@gnu.org; Thu, 29 Nov 2007 02:24:13 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ixdkq-0008O3-8g for emacs-devel@gnu.org; Thu, 29 Nov 2007 02:24:12 -0500 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ixdkq-0007ZD-1Q for emacs-devel@gnu.org; Thu, 29 Nov 2007 02:24:12 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id lAT7M7L4017604; Wed, 28 Nov 2007 23:22:07 -0800 (PST) In-Reply-To: <87ir3nl5fp.fsf@wine.dyndns.org> (Alexandre Julliard's message of "Tue, 27 Nov 2007 22:55:06 +0100") Original-Lines: 22 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84281 Archived-At: Alexandre Julliard writes: > Thien-Thi Nguyen writes: > > > i think `vc-git-dired-state-info' should call `vc-git-state' > > instead of `vc-state'. here is a recipe: create dir `test', > > put it under git version control system, add and commit some > > files, then modify a subset of the files. then do: > > > > C-x v d test RET ; => empty because no files "locked" > > v t ; => toggle terse mode > > > > before the patch, no files are shown w/ "(modified)" status. > > after the patch, some are shown, as i expected. > > > > i wonder if my expectation is incorrect. comments? > > That's not the real problem, the other backends also use vc-state here > and it works fine. The real problem is that vc-git-dir-state is > broken. Something like this should help: Thanks, I've checked in this patch.