unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: Alexandre Julliard <julliard@winehq.org>
Cc: Thien-Thi Nguyen <ttn@gnuvola.org>, emacs-devel@gnu.org
Subject: Re: [patch] vc-git-dired-state-info buglet
Date: Wed, 28 Nov 2007 23:22:03 -0800	[thread overview]
Message-ID: <200711290722.lAT7M7L4017604@oogie-boogie.ics.uci.edu> (raw)
In-Reply-To: <87ir3nl5fp.fsf@wine.dyndns.org> (Alexandre Julliard's message of "Tue, 27 Nov 2007 22:55:06 +0100")

Alexandre Julliard <julliard@winehq.org> writes:

  > Thien-Thi Nguyen <ttn@gnuvola.org> writes:
  > 
  > > i think `vc-git-dired-state-info' should call `vc-git-state'
  > > instead of `vc-state'.  here is a recipe: create dir `test',
  > > put it under git version control system, add and commit some
  > > files, then modify a subset of the files.  then do:
  > >
  > > C-x v d test RET  ; => empty because no files "locked"
  > > v t               ; => toggle terse mode
  > >
  > > before the patch, no files are shown w/ "(modified)" status.
  > > after the patch, some are shown, as i expected.
  > >
  > > i wonder if my expectation is incorrect.  comments?
  > 
  > That's not the real problem, the other backends also use vc-state here
  > and it works fine. The real problem is that vc-git-dir-state is
  > broken. Something like this should help:

Thanks, I've checked in this patch.

      reply	other threads:[~2007-11-29  7:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-23 12:09 [patch] vc-git-dired-state-info buglet Thien-Thi Nguyen
2007-11-27 21:55 ` Alexandre Julliard
2007-11-29  7:22   ` Dan Nicolaescu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711290722.lAT7M7L4017604@oogie-boogie.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=julliard@winehq.org \
    --cc=ttn@gnuvola.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).