From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas =?iso-8859-1?q?R=F6hler?= Newsgroups: gmane.emacs.devel Subject: Re: Useless change in lisp.el? Date: Mon, 26 Nov 2007 20:58:24 +0100 Message-ID: <200711262058.25592.andreas.roehler@online.de> References: <200711251755.50891.andreas.roehler@online.de> <200711261914.34853.andreas.roehler@online.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1196107332 19639 80.91.229.12 (26 Nov 2007 20:02:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 26 Nov 2007 20:02:12 +0000 (UTC) Cc: Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 26 21:02:19 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Iwk9r-0008Ci-IP for ged-emacs-devel@m.gmane.org; Mon, 26 Nov 2007 21:02:19 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iwk9c-0004jZ-L3 for ged-emacs-devel@m.gmane.org; Mon, 26 Nov 2007 15:02:04 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Iwk9Z-0004j0-Fr for emacs-devel@gnu.org; Mon, 26 Nov 2007 15:02:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Iwk9X-0004iX-Gh for emacs-devel@gnu.org; Mon, 26 Nov 2007 15:02:00 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iwk9X-0004iU-CJ for emacs-devel@gnu.org; Mon, 26 Nov 2007 15:01:59 -0500 Original-Received: from moutng.kundenserver.de ([212.227.126.183]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Iwk9W-0002Ng-LY for emacs-devel@gnu.org; Mon, 26 Nov 2007 15:01:58 -0500 Original-Received: from noname (p54BE91FC.dip0.t-ipconnect.de [84.190.145.252]) by mrelayeu.kundenserver.de (node=mrelayeu4) with ESMTP (Nemesis) id 0ML21M-1Iwk9U3d22-0002gk; Mon, 26 Nov 2007 21:01:57 +0100 User-Agent: KMail/1.9.5 In-Reply-To: Content-Disposition: inline X-Provags-ID: V01U2FsdGVkX1/c+wuTnCfJt1Q1oDCfZfWtWzBSNDNw+8iSEn9 2k7INcl1wr/xkoHL1F8YExzYHwpWIiTEFnjHy6FSb/Jehs/51x EgUkKuJytOSGpeS3TE9EQ== X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84164 Archived-At: Am Montag, 26. November 2007 20:26 schrieb Stefan Monnier: > > Should you not cling to much to that disputed change > > and no one else defends it, I would appreciate much > > seeing it reverted. > > Rather than argue abuot the change itself, just give us some use > case where the new behavior is problematic. > Can't see any new behaviour with this change, that's it. AFAIU you introduced more lines of code and provision for possible bugs not to fear before. ;; In case the beginning-of-defun-function uses the old calling ;; convention, fallback on the old implementation. (wrong-number-of-arguments (if (> arg 0) (dotimes (i arg) (funcall beginning-of-defun-function)) ;; Better not call end-of-defun-function directly, in case ;; it's not defined. (end-of-defun (- arg)))))) Now you have the old implementation, called if `(wrong-number-of-arguments'--what wasn't at the table before--new implementation and the default as always: Three instead of two items to watch. If you want Emacs as extendable, it matters, how the code is written. If you introduce things without valid reason--that's my view still--it will be less readable, people need more time to dig through. Andreas R=F6hler