From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: byte compiling defcustom Date: Sat, 17 Nov 2007 10:47:17 -0600 (CST) Message-ID: <200711171647.lAHGlHqH024027@jane.dms.auburn.edu> References: NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1195318167 13417 80.91.229.12 (17 Nov 2007 16:49:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 17 Nov 2007 16:49:27 +0000 (UTC) Cc: dann@ics.uci.edu, rms@gnu.org, emacs-devel@gnu.org To: monnier@iro.umontreal.ca Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 17 17:49:33 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ItQrM-0006Bv-ET for ged-emacs-devel@m.gmane.org; Sat, 17 Nov 2007 17:49:32 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ItQr9-0003Lb-37 for ged-emacs-devel@m.gmane.org; Sat, 17 Nov 2007 11:49:19 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ItQr5-0003LE-Dv for emacs-devel@gnu.org; Sat, 17 Nov 2007 11:49:15 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ItQr4-0003Il-2e for emacs-devel@gnu.org; Sat, 17 Nov 2007 11:49:14 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ItQr3-0003Ia-Um for emacs-devel@gnu.org; Sat, 17 Nov 2007 11:49:13 -0500 Original-Received: from manatee.dms.auburn.edu ([131.204.53.104]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1ItQqy-0006fB-GT; Sat, 17 Nov 2007 11:49:08 -0500 Original-Received: from jane.dms.auburn.edu (jane.dms.auburn.edu [131.204.53.201]) by manatee.dms.auburn.edu (8.13.7+Sun/8.13.7) with ESMTP id lAHGn6bU014441; Sat, 17 Nov 2007 10:49:06 -0600 (CST) Original-Received: from jane.dms.auburn.edu (localhost [127.0.0.1]) by jane.dms.auburn.edu (8.13.4+Sun/8.13.4) with ESMTP id lAHGlIsQ024030; Sat, 17 Nov 2007 10:47:18 -0600 (CST) Original-Received: (from teirllm@localhost) by jane.dms.auburn.edu (8.13.4+Sun/8.13.3/Submit) id lAHGlHqH024027; Sat, 17 Nov 2007 10:47:17 -0600 (CST) X-Authentication-Warning: jane.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f In-reply-to: (message from Stefan Monnier on Fri, 16 Nov 2007 10:25:13 -0500) X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83457 Archived-At: Stefan Monnier wrote: The patch below implements the desired feature: it byte-compiles the default-value-expression (first part of the hunk) as well as any keyword arguments (second part of the hunk) I did not try the patch, but I can not see how this would _not_ ruin the "Show Saved Lisp Expression" feature in the State buttons in Custom buffers by showing byte code instead of Lisp code that the user can edit. Does it not? FWIW the size of a tar file containing all the elc files in emacs went from 29511680 to 29491200 after this patch. Not the best metric, but it shows that the patch has some impact. I do not know whether the "some impact" above was meant seriously or ironically, but the "impact" is less than 0.07 percent, that is, for all practical purposes inexistent. Definitely not worth ruining a feature for. Sincerely, Luc Teirlinck.