From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: ediff and coding systems Date: Sat, 27 Oct 2007 14:03:15 -0700 Message-ID: <200710272103.l9RL3Gai024901@oogie-boogie.ics.uci.edu> References: <22573.1193025009@cs.sunysb.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1193519041 1822 80.91.229.12 (27 Oct 2007 21:04:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 27 Oct 2007 21:04:01 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: kifer@cs.sunysb.edu (Michael Kifer) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 27 23:04:02 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ilsp8-0004yC-8u for ged-emacs-devel@m.gmane.org; Sat, 27 Oct 2007 23:04:02 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ilsoz-0006J1-Be for ged-emacs-devel@m.gmane.org; Sat, 27 Oct 2007 17:03:53 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ilsou-0006GK-DB for emacs-devel@gnu.org; Sat, 27 Oct 2007 17:03:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ilsot-0006FQ-Ky for emacs-devel@gnu.org; Sat, 27 Oct 2007 17:03:48 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ilsot-0006FK-Hq for emacs-devel@gnu.org; Sat, 27 Oct 2007 17:03:47 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ilsop-00076l-2i; Sat, 27 Oct 2007 17:03:43 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l9RL3Gai024901; Sat, 27 Oct 2007 14:03:16 -0700 (PDT) In-Reply-To: <22573.1193025009@cs.sunysb.edu> (Michael Kifer's message of "Sun\, 21 Oct 2007 23\:50\:09 -0400") Original-Lines: 32 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81882 Archived-At: kifer@cs.sunysb.edu (Michael Kifer) writes: > > kifer@cs.sunysb.edu (Michael Kifer) writes: > > > > > > kifer@cs.sunysb.edu (Michael Kifer) writes: > > > > > > This one is strange > > > > > > viper-cmd.el:5099:1:Warning: the following functions are not known to > > be defined: quail-input-method, quail-start-translation, > > event-to-character, character-to-event, viper-iconify, key-press-event-p, event-key, > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > These should be optimized out by the byte compiler. > > No idea. The above are mostly XEmacs functions. These warnings show up because the XEmacs functions are conditionally called with the condition being the viper-xemacs-p defconst. Defconsts cannot be optimized out at compile time. > > Also viper-xemacs-p is about as long as (featurep 'emacs) and as > > readable. Why not replace it? Most similar macros have been replaced > > in CVS. > > > I do not really care, but see no reason why waste time on this one. Would you mind if I do it? For viper* and ediff* ? Doing this will allow the byte compiler to get rid code at compile time, this saves a few kilobytes of disk space.