[PATCH] desktop.el: do not save some minor modes

[PATCH] desktop.el: do not save some minor modes

[Levin]

I use desktop.el, and find that it will save all the minor modes, which is not 
proper. Like erc-track-mode, if ERC is not started, this minor mode is 
meaningless. 

So I add a customizable variable `desktop-minor-modes-not-to-save' to handle 
this situation.

--
Levin

--- a/lisp/desktop.el
+++ b/lisp/desktop.el
@@ -355,6 +355,12 @@ modes are restored automatically; they should not be 
listed here."
   :type '(repeat symbol)
   :group 'desktop)
 
+(defcustom desktop-minor-modes-not-to-save
+  '(erc-track-minor-mode)
+  "List of major modes whose buffers should not be saved."
+  :type '(repeat symbol)
+  :group 'desktop)
+
 (defcustom desktop-file-name-format 'absolute
   "*Format in which desktop file names should be saved.
 Possible values are:
@@ -661,6 +667,7 @@ is nil, ask the user where to save the desktop."
       #'(lambda (minor-mode)
 	  (and (boundp minor-mode)
 	       (symbol-value minor-mode)
+	       (not (memq minor-mode desktop-minor-modes-not-to-save))
 	       (let* ((special (assq minor-mode desktop-minor-mode-table))
 		      (value (cond (special (cadr special))
 				   ((functionp minor-mode) minor-mode))))

Re: [PATCH] desktop.el: do not save some minor modes

[martin rudalics]

> +(defcustom desktop-minor-modes-not-to-save
> +  '(erc-track-minor-mode)
> +  "List of major modes whose buffers should not be saved."

You probably mean something like

 > +  "List of minor modes that should not be saved by desktop."

here.

Re: [PATCH] desktop.el: do not save some minor modes

[Levin]

martin rudalics wrote:
> > +(defcustom desktop-minor-modes-not-to-save
> > +  '(erc-track-minor-mode)
> > +  "List of major modes whose buffers should not be saved."
>
> You probably mean something like
>
>  > +  "List of minor modes that should not be saved by desktop."
>
> here.

Oh yes, you're right :) Fast copy-paste problem.

--
Levin

Re: [PATCH] desktop.el: do not save some minor modes

[Juanma Barranquero]

On 10/25/07, Levin <zslevin@gmail.com> wrote:

> I use desktop.el, and find that it will save all the minor modes, which is not
> proper. Like erc-track-mode, if ERC is not started, this minor mode is
> meaningless.

Isn't enough to add (erc-track-mode nil) to `desktop-minor-mode-table'?

             Juanma

Re: [PATCH] desktop.el: do not save some minor modes

[Levin]

Juanma Barranquero Wrote:
> On 10/25/07, Levin <zslevin@gmail.com> wrote:
> > I use desktop.el, and find that it will save all the minor modes, which
> > is not proper. Like erc-track-mode, if ERC is not started, this minor
> > mode is meaningless.
>
> Isn't enough to add (erc-track-mode nil) to `desktop-minor-mode-table'?
>
>              Juanma

Yes, you are right. That's enough. Thank you for pointing that out.

Levin

Re: [PATCH] desktop.el: do not save some minor modes

[Richard Stallman]

What do people think of this patch?  The feature seems useful.  Does
anyone see a reason to do it differently?

Re: [PATCH] desktop.el: do not save some minor modes

[Levin]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 311 bytes --]

On Friday 11:49:13£¬Richard Stallman wrote£º
> What do people think of this patch?  The feature seems useful.  Does
> anyone see a reason to do it differently?

This line:

   (add-to-list 'desktop-minor-mode-table '(erc-track-minor-mode nil))

solves my problem, so this patch is not needed.

Levin

Re: [PATCH] desktop.el: do not save some minor modes

[Juanma Barranquero]

On 10/26/07, Levin <zslevin@gmail.com> wrote:

> This line:
>
>    (add-to-list 'desktop-minor-mode-table '(erc-track-minor-mode nil))
>
> solves my problem, so this patch is not needed.

OTOH, if restoring erc-track-minor-mode from desktop is never a
meaningful operation, we should patch erc-track.el to add it
automatically to `desktop-minor-mode-table'.

             Juanma

Re: [PATCH] desktop.el: do not save some minor modes

[Richard Stallman]

       (add-to-list 'desktop-minor-mode-table '(erc-track-minor-mode nil))

    solves my problem, so this patch is not needed.

Should we do that by default?  Is it clear that users will
prefer not to record that minor mode?

Re: [PATCH] desktop.el: do not save some minor modes

[Michael Olson]

[-- Attachment #1.1: Type: text/plain, Size: 593 bytes --]

Richard Stallman <rms@gnu.org> writes:

>        (add-to-list 'desktop-minor-mode-table '(erc-track-minor-mode nil))
>
>     solves my problem, so this patch is not needed.
>
> Should we do that by default?  Is it clear that users will
> prefer not to record that minor mode?

I've now checked in a change to this effect.

-- 
       Michael Olson -- FSF Associate Member #652     |
 http://mwolson.org/ -- Jabber: mwolson_at_hcoop.net  |  /` |\ | | |
            Sysadmin -- Hobbies: Lisp, GP2X, HCoop    | |_] | \| |_|
Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: [PATCH] desktop.el: do not save some minor modes

[CHENG Gao]

>>        (add-to-list 'desktop-minor-mode-table '(erc-track-minor-mode
>> nil))
>> solves my problem, so this patch is not needed.
>> Should we do that by default? Is it clear that users will prefer not
>> to record that minor mode?
>
> I've now checked in a change to this effect.

After this change this is one thing annoying - I have to (require
'desktop) to use erc even I dont use desktop.el otherwise an error is
triggered telling desktop-minor-mode-table not existed or something. I
think it's a bug.

Re: [PATCH] desktop.el: do not save some minor modes

[Michael Olson]

[-- Attachment #1.1: Type: text/plain, Size: 999 bytes --]

CHENG Gao <chenggao@gmail.com> writes:

>>>        (add-to-list 'desktop-minor-mode-table '(erc-track-minor-mode
>>> nil))
>>> solves my problem, so this patch is not needed.
>>> Should we do that by default? Is it clear that users will prefer not
>>> to record that minor mode?
>>
>> I've now checked in a change to this effect.
>
> After this change this is one thing annoying - I have to (require
> 'desktop) to use erc even I dont use desktop.el otherwise an error is
> triggered telling desktop-minor-mode-table not existed or something. I
> think it's a bug.

OK, I've now moved the line into the definition of
desktop-minor-mode-table itself, which seems to be what other modes do.
This should fix the annoyance.

-- 
       Michael Olson -- FSF Associate Member #652     |
 http://mwolson.org/ -- Jabber: mwolson_at_hcoop.net  |  /` |\ | | |
            Sysadmin -- Hobbies: Lisp, GP2X, HCoop    | |_] | \| |_|
Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: [PATCH] desktop.el: do not save some minor modes

[CHENG Gao]

> OK, I've now moved the line into the definition of
> desktop-minor-mode-table itself, which seems to be what other modes do.
> This should fix the annoyance.
Thanks. It works now.