From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: doc-view compilation warnings Date: Tue, 23 Oct 2007 09:07:14 -0700 Message-ID: <200710231607.l9NG7EoD016139@oogie-boogie.ics.uci.edu> References: <87wsth6vk5.fsf@catnip.gol.com> <878x5wrgnv.fsf@baldur.tsdh.de> <87prz6yn1c.fsf@baldur.tsdh.de> <200710231430.l9NEUk8x012690@oogie-boogie.ics.uci.edu> <87ejflzv18.fsf@baldur.tsdh.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1193155861 1336 80.91.229.12 (23 Oct 2007 16:11:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Oct 2007 16:11:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 23 18:11:02 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IkMLN-0003tk-KK for ged-emacs-devel@m.gmane.org; Tue, 23 Oct 2007 18:11:01 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IkMLF-0003pS-Kj for ged-emacs-devel@m.gmane.org; Tue, 23 Oct 2007 12:10:53 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IkMJi-00035T-PU for emacs-devel@gnu.org; Tue, 23 Oct 2007 12:09:18 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IkMJg-000346-44 for emacs-devel@gnu.org; Tue, 23 Oct 2007 12:09:18 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IkMJf-00033o-QJ for emacs-devel@gnu.org; Tue, 23 Oct 2007 12:09:15 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IkMJb-0006mj-BN; Tue, 23 Oct 2007 12:09:11 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l9NG7EoD016139; Tue, 23 Oct 2007 09:07:25 -0700 (PDT) In-Reply-To: <87ejflzv18.fsf@baldur.tsdh.de> (Tassilo Horn's message of "Tue\, 23 Oct 2007 17\:54\:11 +0200") Original-Lines: 55 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-0.84, required 5, autolearn=disabled, ALL_TRUSTED -1.44, J_CHICKENPOX_52 0.60) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81570 Archived-At: Tassilo Horn writes: > Dan Nicolaescu writes: > > Hi Dan, > > > Please add ChangeLog entries when sending patches. > > The patch contains ChangeLog entries. (The last part of it.) It is not a good idea to do the add the ChangeLog entry as a diff, it rarely still applies cleanly at the time it is checked in. Include it as plain text before that patch, so that it is easier to see what the patch is about. > > > The patch is also at http://www.tsdh.de/stuff/doc-view.patch > > > > > > --- lisp/files.el 21 Oct 2007 10:48:28 -0000 1.936 > > > +++ lisp/files.el 23 Oct 2007 12:53:00 -0000 > > > @@ -2060,7 +2060,8 @@ > > > ("\\.\\(diffs?\\|patch\\|rej\\)\\'" . diff-mode) > > > ("\\.\\(dif\\|pat\\)\\'" . diff-mode) ; for MSDOG > > > ("\\.[eE]?[pP][sS]\\'" . ps-mode) > > > - ("\\.\\(?:PDF\\|DVI\\|pdf\\|dvi\\)" . doc-view-mode) > > > + ("\\.[Pp][Dd][Ff]\\'" . ps-mode) > > > + ("\\.[Dd][Vv][Ii]\\'" . fundamental-mode) > > > ("configure\\.\\(ac\\|in\\)\\'" . autoconf-mode) > > > ("BROWSE\\'" . ebrowse-tree-mode) > > > ("\\.ebrowse\\'" . ebrowse-tree-mode) > > > Index: lisp/doc-view.el > > > =================================================================== > > > RCS file: /sources/emacs/emacs/lisp/doc-view.el,v > > > retrieving revision 1.11 > > > diff -u -r1.11 doc-view.el > > > --- lisp/doc-view.el 19 Oct 2007 16:03:09 -0000 1.11 > > > +++ lisp/doc-view.el 23 Oct 2007 12:53:01 -0000 > > > @@ -104,6 +104,10 @@ > > > (require 'image-mode) > > > (eval-when-compile (require 'cl)) > > > > > > +;;;###autoload (push '("\\.[eE]?[pP][sS]\\'" . doc-view-mode-maybe) auto-mode-alist) > > > +;;;###autoload (push '("\\.[Dd][Vv][Ii]\\'" . doc-view-mode-maybe) auto-mode-alist) > > > +;;;###autoload (push '("\\.[Pp][Dd][Ff]\\'" . doc-view-mode-maybe) auto-mode-alist) > > > > Given that you are changing auto-mode-alist alist directly, why not > > put all the auto-mode-alist manipulation in files.el? It's a bit > > confusing to see this done in 2 places. > > This way it only affects users that want to use doc-view (by requiring > it explicitly). If we say that it should be loaded by default, then I > agree with you. But I'm sure there are a lot people that prefer it not > to be loaded by default. I am not sure I get what you are trying to say. Adding autoloads like that will result that code to be loaded by default...