From: Dan Nicolaescu <dann@ics.uci.edu>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: doc-view compilation warnings
Date: Tue, 23 Oct 2007 07:30:46 -0700 [thread overview]
Message-ID: <200710231430.l9NEUk8x012690@oogie-boogie.ics.uci.edu> (raw)
In-Reply-To: <87prz6yn1c.fsf@baldur.tsdh.de> (Tassilo Horn's message of "Tue\, 23 Oct 2007 15\:32\:15 +0200")
Tassilo Horn <tassilo@member.fsf.org> writes:
> Richard Stallman <rms@gnu.org> writes:
>
> > Yes, I know. I'll fix those after my latest patch got applied.
> > So what is the convention? Is calling a cl-function at runtime
> > strictly forbidden?
> >
> > Yes.
>
> Ok, this patch fixes this issue plus the "open dvi/pdf files with
> doc-view and ps-files with ps-mode by default" issue. (See message
> <877ilj45zn.fsf@baldur.tsdh.de> and its follow-ups.)
>
> The only thing that remains is to find another keybinding for toggling
> between editing and viewing with doc-view, because ps-mode already uses
> `C-c C-c'. Suggestions?
Please add ChangeLog entries when sending patches.
> The patch is also at http://www.tsdh.de/stuff/doc-view.patch
>
> --- lisp/files.el 21 Oct 2007 10:48:28 -0000 1.936
> +++ lisp/files.el 23 Oct 2007 12:53:00 -0000
> @@ -2060,7 +2060,8 @@
> ("\\.\\(diffs?\\|patch\\|rej\\)\\'" . diff-mode)
> ("\\.\\(dif\\|pat\\)\\'" . diff-mode) ; for MSDOG
> ("\\.[eE]?[pP][sS]\\'" . ps-mode)
> - ("\\.\\(?:PDF\\|DVI\\|pdf\\|dvi\\)" . doc-view-mode)
> + ("\\.[Pp][Dd][Ff]\\'" . ps-mode)
> + ("\\.[Dd][Vv][Ii]\\'" . fundamental-mode)
> ("configure\\.\\(ac\\|in\\)\\'" . autoconf-mode)
> ("BROWSE\\'" . ebrowse-tree-mode)
> ("\\.ebrowse\\'" . ebrowse-tree-mode)
> Index: lisp/doc-view.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/doc-view.el,v
> retrieving revision 1.11
> diff -u -r1.11 doc-view.el
> --- lisp/doc-view.el 19 Oct 2007 16:03:09 -0000 1.11
> +++ lisp/doc-view.el 23 Oct 2007 12:53:01 -0000
> @@ -104,6 +104,10 @@
> (require 'image-mode)
> (eval-when-compile (require 'cl))
>
> +;;;###autoload (push '("\\.[eE]?[pP][sS]\\'" . doc-view-mode-maybe) auto-mode-alist)
> +;;;###autoload (push '("\\.[Dd][Vv][Ii]\\'" . doc-view-mode-maybe) auto-mode-alist)
> +;;;###autoload (push '("\\.[Pp][Dd][Ff]\\'" . doc-view-mode-maybe) auto-mode-alist)
Given that you are changing auto-mode-alist alist directly, why not
put all the auto-mode-alist manipulation in files.el? It's a bit
confusing to see this done in 2 places.
next prev parent reply other threads:[~2007-10-23 14:30 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-21 2:38 doc-view compilation warnings Miles Bader
2007-10-21 8:55 ` Tassilo Horn
2007-10-22 9:00 ` Richard Stallman
2007-10-23 13:32 ` Tassilo Horn
2007-10-23 14:30 ` Dan Nicolaescu [this message]
2007-10-23 15:54 ` Tassilo Horn
2007-10-23 16:07 ` Dan Nicolaescu
2007-10-23 17:50 ` Tassilo Horn
2007-10-23 18:35 ` Dan Nicolaescu
2007-10-23 18:41 ` Tassilo Horn
2007-10-23 19:00 ` Stefan Monnier
2007-10-23 20:00 ` Tassilo Horn
2007-10-23 21:53 ` Stefan Monnier
2007-10-24 7:59 ` Tassilo Horn
2007-10-24 11:40 ` Tassilo Horn
2007-10-24 15:24 ` Tassilo Horn
2007-10-26 10:52 ` doc-view.patch waiting for installation (was: doc-view compilation warnings) Tassilo Horn
2007-10-29 1:52 ` doc-view.patch waiting for installation Glenn Morris
2007-10-29 9:36 ` Tassilo Horn
2007-10-30 6:33 ` Glenn Morris
2007-10-30 18:07 ` Case folding for auto-mode-alist (was: doc-view.patch waiting for installation) Reiner Steib
2007-10-30 19:00 ` Case folding for auto-mode-alist Stefan Monnier
2007-10-31 7:47 ` Richard Stallman
2007-10-31 15:19 ` Stefan Monnier
2007-10-31 15:30 ` David Kastrup
2007-10-31 16:17 ` Stefan Monnier
2007-10-24 13:55 ` doc-view compilation warnings Stefan Monnier
2007-10-24 14:32 ` Tassilo Horn
2007-10-24 8:33 ` Richard Stallman
2007-10-24 8:32 ` Richard Stallman
2007-10-24 8:32 ` Richard Stallman
2007-10-24 8:32 ` Richard Stallman
2007-10-24 2:49 ` Richard Stallman
2007-10-24 2:49 ` Richard Stallman
2007-10-24 8:11 ` Tassilo Horn
2007-10-24 8:19 ` David Kastrup
2007-10-25 2:10 ` Richard Stallman
2007-10-25 8:09 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710231430.l9NEUk8x012690@oogie-boogie.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).