From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric S. Raymond" Newsgroups: gmane.emacs.devel Subject: Re: C-x v v no longer works the way it used to Date: Sat, 20 Oct 2007 17:07:50 -0400 Organization: Eric Conspiracy Secret Labs Message-ID: <20071020210750.GA7341@thyrsus.com> References: <87r6jxctcv.fsf@rho.meyering.net> <200710192321.l9JNLebF010003@oogie-boogie.ics.uci.edu> Reply-To: esr@thyrsus.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1192914429 11478 80.91.229.12 (20 Oct 2007 21:07:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 20 Oct 2007 21:07:09 +0000 (UTC) Cc: Emacs development discussions , Stefan Monnier , Jim Meyering To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 20 23:06:58 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IjLX6-0003KW-2N for ged-emacs-devel@m.gmane.org; Sat, 20 Oct 2007 23:06:56 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IjLWy-0004py-C6 for ged-emacs-devel@m.gmane.org; Sat, 20 Oct 2007 17:06:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IjLWu-0004oK-De for emacs-devel@gnu.org; Sat, 20 Oct 2007 17:06:44 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IjLWt-0004nr-W3 for emacs-devel@gnu.org; Sat, 20 Oct 2007 17:06:44 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IjLWt-0004ng-SQ for emacs-devel@gnu.org; Sat, 20 Oct 2007 17:06:43 -0400 Original-Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5] helo=snark) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IjLWt-0005nZ-Bu for emacs-devel@gnu.org; Sat, 20 Oct 2007 17:06:43 -0400 Original-Received: by snark (Postfix, from userid 23) id 5E5343807C; Sat, 20 Oct 2007 17:07:50 -0400 (EDT) Content-Disposition: inline In-Reply-To: <200710192321.l9JNLebF010003@oogie-boogie.ics.uci.edu> X-Eric-Conspiracy: There is no conspiracy User-Agent: Mutt/1.5.15+20070412 (2007-04-11) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81315 Archived-At: Dan Nicolaescu : > This patch fixes it. > vc-next-action still has the logic to deal with unregistered files, > but vc-deduce-fileset would not return one... > This patch is technically incorrect because it changes > vc-deduce-fileset to not do what it's docs says it has to do. > Not sure how the new VC design is supposed to work to fix it > properly... You had the right general idea; the strategy has to go through vc-deduce-fileset in order not to break the design. But your patch produces behavior that won't be welcome in commands other than vc-next-action, so I put the arm you added under control of a new boolean argument ALLOW-UNREGISTERED. -- Eric S. Raymond