From: "Eric S. Raymond" <esr@thyrsus.com>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: Emacs development discussions <emacs-devel@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
Jim Meyering <jim@meyering.net>
Subject: Re: C-x v v no longer works the way it used to
Date: Sat, 20 Oct 2007 17:07:50 -0400 [thread overview]
Message-ID: <20071020210750.GA7341@thyrsus.com> (raw)
In-Reply-To: <200710192321.l9JNLebF010003@oogie-boogie.ics.uci.edu>
Dan Nicolaescu <dann@ics.uci.edu>:
> This patch fixes it.
> vc-next-action still has the logic to deal with unregistered files,
> but vc-deduce-fileset would not return one...
> This patch is technically incorrect because it changes
> vc-deduce-fileset to not do what it's docs says it has to do.
> Not sure how the new VC design is supposed to work to fix it
> properly...
You had the right general idea; the strategy has to go through
vc-deduce-fileset in order not to break the design. But your patch
produces behavior that won't be welcome in commands other than
vc-next-action, so I put the arm you added under control of
a new boolean argument ALLOW-UNREGISTERED.
--
<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>
next prev parent reply other threads:[~2007-10-20 21:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-14 20:51 C-x v v no longer works the way it used to Jim Meyering
2007-10-14 21:01 ` Eric Hanchrow
2007-10-14 22:51 ` Miles Bader
2007-10-15 0:50 ` Stefan Monnier
2007-10-15 2:09 ` Eric S. Raymond
2007-10-19 23:21 ` Dan Nicolaescu
2007-10-20 16:56 ` Jim Meyering
2007-10-20 21:07 ` Eric S. Raymond [this message]
2007-10-21 2:59 ` Dan Nicolaescu
2007-11-12 15:32 ` Dan Nicolaescu
2007-11-13 16:48 ` Dan Nicolaescu
2007-11-14 10:54 ` Jim Meyering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071020210750.GA7341@thyrsus.com \
--to=esr@thyrsus.com \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=jim@meyering.net \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).