From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric S. Raymond" Newsgroups: gmane.emacs.devel Subject: Re: Emacs-devel Digest, Vol 44, Issue 99 Date: Sat, 20 Oct 2007 00:42:50 -0400 Organization: Eric Conspiracy Secret Labs Message-ID: <20071020044250.GB710@thyrsus.com> References: <20071013195054.0C7B573931@grelber.thyrsus.com> Reply-To: esr@thyrsus.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1192855318 22409 80.91.229.12 (20 Oct 2007 04:41:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 20 Oct 2007 04:41:58 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 20 06:41:58 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ij69r-0003oq-Iy for ged-emacs-devel@m.gmane.org; Sat, 20 Oct 2007 06:41:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ij69k-0001AW-07 for ged-emacs-devel@m.gmane.org; Sat, 20 Oct 2007 00:41:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ij69h-0001AR-QC for emacs-devel@gnu.org; Sat, 20 Oct 2007 00:41:45 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ij69h-0001AE-Cf for emacs-devel@gnu.org; Sat, 20 Oct 2007 00:41:45 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ij69h-0001AA-A4 for emacs-devel@gnu.org; Sat, 20 Oct 2007 00:41:45 -0400 Original-Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5] helo=snark) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ij69h-0000ff-41 for emacs-devel@gnu.org; Sat, 20 Oct 2007 00:41:45 -0400 Original-Received: by snark (Postfix, from userid 23) id 5AF8E3807C; Sat, 20 Oct 2007 00:42:50 -0400 (EDT) Content-Disposition: inline In-Reply-To: <20071013195054.0C7B573931@grelber.thyrsus.com> X-Eric-Conspiracy: There is no conspiracy User-Agent: Mutt/1.5.15+20070412 (2007-04-11) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81287 Archived-At: > Message: 3 > Date: Sat, 13 Oct 2007 10:44:21 -0700 > From: Dan Nicolaescu > Subject: Re: log-view.el calls non-existent function vc-version-diff > To: "Chris Moore" > Cc: "Eric S. Raymond" , emacs-pretest-bug@gnu.org > Message-ID: <200710131744.l9DHiL4Z023009@oogie-boogie.ics.uci.edu> > Content-Type: text/plain; charset=us-ascii > > "Chris Moore" writes: > > > The only 2 references to vc-version-diff in the whole lisp/ tree are: > > > > ./log-view.el:(autoload 'vc-version-diff "vc") > > ./log-view.el: (vc-version-diff (log-view-current-file) to fr))) > > It seems that it should be changed to call vc-history-diff. > > But vc-history-diff takes a `backend' parameter. But it computes the > backend in the code anyway... > > ESR, can you please say what is your intention with that function? > Should it just lose the `backend' parameter? vc-history-diff is dead. vc-version-diff is the right function to be calling, but it now takes a fileset rather than a file as first paramater. I have modified log-view.el appropriately. -- Eric S. Raymond