* Re: Emacs-devel Digest, Vol 44, Issue 99
[not found] <20071013195054.0C7B573931@grelber.thyrsus.com>
@ 2007-10-20 4:42 ` Eric S. Raymond
0 siblings, 0 replies; only message in thread
From: Eric S. Raymond @ 2007-10-20 4:42 UTC (permalink / raw)
To: emacs-devel
> Message: 3
> Date: Sat, 13 Oct 2007 10:44:21 -0700
> From: Dan Nicolaescu <dann@ics.uci.edu>
> Subject: Re: log-view.el calls non-existent function vc-version-diff
> To: "Chris Moore" <christopher.ian.moore@gmail.com>
> Cc: "Eric S. Raymond" <esr@thyrsus.com>, emacs-pretest-bug@gnu.org
> Message-ID: <200710131744.l9DHiL4Z023009@oogie-boogie.ics.uci.edu>
> Content-Type: text/plain; charset=us-ascii
>
> "Chris Moore" <christopher.ian.moore@gmail.com> writes:
>
> > The only 2 references to vc-version-diff in the whole lisp/ tree are:
> >
> > ./log-view.el:(autoload 'vc-version-diff "vc")
> > ./log-view.el: (vc-version-diff (log-view-current-file) to fr)))
>
> It seems that it should be changed to call vc-history-diff.
>
> But vc-history-diff takes a `backend' parameter. But it computes the
> backend in the code anyway...
>
> ESR, can you please say what is your intention with that function?
> Should it just lose the `backend' parameter?
vc-history-diff is dead.
vc-version-diff is the right function to be calling, but it now takes
a fileset rather than a file as first paramater.
I have modified log-view.el appropriately.
--
<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-10-20 4:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20071013195054.0C7B573931@grelber.thyrsus.com>
2007-10-20 4:42 ` Emacs-devel Digest, Vol 44, Issue 99 Eric S. Raymond
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).