From: "Eric S. Raymond" <esr@thyrsus.com>
To: emacs-devel@gnu.org
Subject: Re: Emacs-devel Digest, Vol 44, Issue 99
Date: Sat, 20 Oct 2007 00:42:50 -0400 [thread overview]
Message-ID: <20071020044250.GB710@thyrsus.com> (raw)
In-Reply-To: <20071013195054.0C7B573931@grelber.thyrsus.com>
> Message: 3
> Date: Sat, 13 Oct 2007 10:44:21 -0700
> From: Dan Nicolaescu <dann@ics.uci.edu>
> Subject: Re: log-view.el calls non-existent function vc-version-diff
> To: "Chris Moore" <christopher.ian.moore@gmail.com>
> Cc: "Eric S. Raymond" <esr@thyrsus.com>, emacs-pretest-bug@gnu.org
> Message-ID: <200710131744.l9DHiL4Z023009@oogie-boogie.ics.uci.edu>
> Content-Type: text/plain; charset=us-ascii
>
> "Chris Moore" <christopher.ian.moore@gmail.com> writes:
>
> > The only 2 references to vc-version-diff in the whole lisp/ tree are:
> >
> > ./log-view.el:(autoload 'vc-version-diff "vc")
> > ./log-view.el: (vc-version-diff (log-view-current-file) to fr)))
>
> It seems that it should be changed to call vc-history-diff.
>
> But vc-history-diff takes a `backend' parameter. But it computes the
> backend in the code anyway...
>
> ESR, can you please say what is your intention with that function?
> Should it just lose the `backend' parameter?
vc-history-diff is dead.
vc-version-diff is the right function to be calling, but it now takes
a fileset rather than a file as first paramater.
I have modified log-view.el appropriately.
--
<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>
parent reply other threads:[~2007-10-20 4:42 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20071013195054.0C7B573931@grelber.thyrsus.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071020044250.GB710@thyrsus.com \
--to=esr@thyrsus.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).