From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: C-x v v no longer works the way it used to Date: Fri, 19 Oct 2007 16:21:31 -0700 Message-ID: <200710192321.l9JNLebF010003@oogie-boogie.ics.uci.edu> References: <87r6jxctcv.fsf@rho.meyering.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1192836236 9937 80.91.229.12 (19 Oct 2007 23:23:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Oct 2007 23:23:56 +0000 (UTC) Cc: "Eric S. Raymond" , Jim Meyering , Emacs development discussions To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 20 01:23:55 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ij1Bt-0002zL-9H for ged-emacs-devel@m.gmane.org; Sat, 20 Oct 2007 01:23:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ij1Bl-0000P3-Fd for ged-emacs-devel@m.gmane.org; Fri, 19 Oct 2007 19:23:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ij1Bi-0000Ox-LW for emacs-devel@gnu.org; Fri, 19 Oct 2007 19:23:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ij1Bh-0000Oh-3o for emacs-devel@gnu.org; Fri, 19 Oct 2007 19:23:29 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ij1Bg-0000Oe-To for emacs-devel@gnu.org; Fri, 19 Oct 2007 19:23:28 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ij1Bg-00084c-If for emacs-devel@gnu.org; Fri, 19 Oct 2007 19:23:28 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l9JNLebF010003; Fri, 19 Oct 2007 16:21:40 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sun\, 14 Oct 2007 20\:50\:36 -0400") Original-Lines: 38 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=1.785, required 5, autolearn=disabled, ALL_TRUSTED -1.44, FS_SINGLE_LETTER 1.00, GAPPY_SUBJECT 1.62, J_CHICKENPOX_22 0.60) X-ICS-MailScanner-SpamScore: s X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81267 Archived-At: Stefan Monnier writes: > > Before the recent vc changes, in a version-controlled directory, > > if I were visiting a non-version-controlled file and hit C-x v v, > > it would effectively add that single file to the version control > > system. i.e., cvs add, git add, etc. > > > Now, all it does is print "No fileset is available here." > > > Is this intentional? > > It's a bug. This patch fixes it. vc-next-action still has the logic to deal with unregistered files, but vc-deduce-fileset would not return one... This patch is technically incorrect because it changes vc-deduce-fileset to not do what it's docs says it has to do. Not sure how the new VC design is supposed to work to fix it properly... Index: vc.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/vc.el,v retrieving revision 1.473 diff -c -3 -p -c -r1.473 vc.el *** vc.el 19 Oct 2007 20:59:49 -0000 1.473 --- vc.el 19 Oct 2007 22:47:56 -0000 *************** Otherwise, throw an error." *** 1283,1288 **** --- 1282,1288 ---- (message "All version-controlled files below %s selected." default-directory) (list default-directory))) + ((not (vc-registered buffer-file-name)) (list buffer-file-name)) (t (error "No fileset is available here."))))