From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Adam Spiers Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: custom-variable-menu loses entries if defined during site-start Date: Tue, 16 Oct 2007 17:50:07 +0100 Message-ID: <20071016165007.GA32678@atlantic.linksys.moosehall> References: <20071007171653.GA11765@atlantic.linksys.moosehall> Reply-To: Adam Spiers NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1192553444 23888 80.91.229.12 (16 Oct 2007 16:50:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Oct 2007 16:50:44 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 16 18:50:44 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ihpcu-0005O8-OW for ged-emacs-devel@m.gmane.org; Tue, 16 Oct 2007 18:50:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ihpcn-0008Sk-S1 for ged-emacs-devel@m.gmane.org; Tue, 16 Oct 2007 12:50:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IhpcZ-0008QJ-3o for emacs-devel@gnu.org; Tue, 16 Oct 2007 12:50:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IhpcW-0008Pz-Rg for emacs-devel@gnu.org; Tue, 16 Oct 2007 12:50:18 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IhpcW-0008Pw-OY for emacs-devel@gnu.org; Tue, 16 Oct 2007 12:50:16 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IhpcW-00079n-Gd for emacs-devel@gnu.org; Tue, 16 Oct 2007 12:50:16 -0400 Original-Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IhpcW-0001k9-2i for emacs-pretest-bug@gnu.org; Tue, 16 Oct 2007 12:50:16 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1IhpcU-00079T-Ch for emacs-pretest-bug@gnu.org; Tue, 16 Oct 2007 12:50:16 -0400 Original-Received: from mail.beimborn.com ([70.84.38.100]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IhpcP-00077l-JL; Tue, 16 Oct 2007 12:50:09 -0400 Original-Received: from mail.beimborn.com (localhost.localdomain [127.0.0.1]) by mail.beimborn.com (8.12.11.20060308/8.12.8) with ESMTP id l9GGo7eG006671; Tue, 16 Oct 2007 11:50:07 -0500 Original-Received: from localhost (localhost [[UNIX: localhost]]) by mail.beimborn.com (8.12.11.20060308/8.12.11/Submit) id l9GGo7ZR006666; Tue, 16 Oct 2007 17:50:07 +0100 X-Authentication-Warning: mail.beimborn.com: adam set sender to f5-sendmail@adamspiers.org using -f Content-Disposition: inline In-Reply-To: X-OS: Linux User-Agent: Mutt/1.5.14 (2007-02-12) X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81013 gmane.emacs.pretest.bugs:20145 Archived-At: On Tue, Oct 09, 2007 at 09:31:14PM -0400, Glenn Morris wrote: > Adam Spiers wrote: > > I noticed that since upgrading to emacs 22, when changing variables > > in a Custom buffer, individual variables no longer offered the "Save > > for Future Sessions" action in the State menu, even when custom-file > > and user-init-file are set correctly. I tracked it down to this > > change: > > > > http://cvs.savannah.gnu.org/viewvc/emacs/lisp/cus-edit.el?root=emacs&view=diff&r1=1.250&r2=1.251 > > > > In particular, in the defvar of custom-variable-menu: > > > > ("Save for Future Sessions" custom-variable-save > > > > is changed to > > > > ,@(when (or custom-file user-init-file) > > '(("Save for Future Sessions" custom-variable-save > > > > This works fine if cus-edit.el is loaded after custom-file and/or > > user-init-file are initialized during startup. > > Perhaps cus-edit could test `init-file-user' instead of `user-init-file'. > Looks like this is set early enough in the startup sequence. Test that it's non-nil, you mean? I guess that could work, though I don't know enough about the startup sequence to know whether `init-file-user' being non-nil implies that `custom-file' or `user-init-file' will be available later on. > > However, on Fedora 7, the emacs-common-22.0.990-2.fc7 rpm > > This is a pretest of Emacs 22. Whoops, so it was. > Is there not a proper Emacs 22.1 package for Fedora 7? Not sure if there was when I installed F7 originally, but there certainly is now. I upgraded, but the problem persists. Can anyone think of a better temporary work-around than using --no-site-file, which is obviously less than ideal? Thanks, Adam