From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: New VC mode -- review request Date: Tue, 09 Oct 2007 08:33:04 -0700 Message-ID: <200710091533.l99FX4kJ028467@oogie-boogie.ics.uci.edu> References: <20071003103501.GA4997@thyrsus.com> <200710031431.l93EVfFZ021233@oogie-boogie.ics.uci.edu> <20071003170048.GB7014@thyrsus.com> <200710040042.l940g1B6012034@oogie-boogie.ics.uci.edu> <20071004020219.GB12134@thyrsus.com> <200710040214.l942EUNr013619@oogie-boogie.ics.uci.edu> <20071009145523.GA3678@thyrsus.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1191944112 7270 80.91.229.12 (9 Oct 2007 15:35:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 9 Oct 2007 15:35:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: esr@thyrsus.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 09 17:35:07 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IfH6Z-0002bJ-6Y for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2007 17:34:43 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IfH6T-00078w-Bj for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2007 11:34:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IfH6Q-00078h-1j for emacs-devel@gnu.org; Tue, 09 Oct 2007 11:34:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IfH6P-00078T-40 for emacs-devel@gnu.org; Tue, 09 Oct 2007 11:34:33 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IfH6O-00078J-U1 for emacs-devel@gnu.org; Tue, 09 Oct 2007 11:34:32 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IfH6O-0006CL-FI for emacs-devel@gnu.org; Tue, 09 Oct 2007 11:34:32 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l99FX4kJ028467; Tue, 9 Oct 2007 08:33:04 -0700 (PDT) In-Reply-To: <20071009145523.GA3678@thyrsus.com> (Eric S. Raymond's message of "Tue\, 9 Oct 2007 10\:55\:24 -0400") Original-Lines: 36 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-0.84, required 5, autolearn=disabled, ALL_TRUSTED -1.44, J_CHICKENPOX_22 0.60) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-Detected-Kernel: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80469 Archived-At: "Eric S. Raymond" writes: > Dan Nicolaescu : > > BTW, I just found another issue: > > with the same setup as above, do: > > cp ~/.emacs /tmp/test/3.el > > > > emacs -q -l vc.el /tmp/test/3.el > > > > C-x v v > > fails with: "No fileset is available here." > > That's correct, because the visited file isn't under version control. That would be a change in long standing behavior, and it is inconsistent with with to docstring for vc-next-action: " If every file is not already registered, this registers each one for version control. This does an add, but not a commit." IMO this behavior is one of the strengths of vc: C-x v v always does TRT. > There's a design argument that maybe something different ought to happen here, > but that's an after-the-merge issue. Sure, just let's make sure it does not get forgotten. Another post merge issue: The code that deals with registering in vc-next-action: ;; Files aren't registered ((not state) (mapc 'vc-register files)) Maybe vc-register could work on a list of files? vc-BACKEND-register already does that..