From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Johannes Weiner Newsgroups: gmane.emacs.devel Subject: Re: [BUG] Dark/bright face detection problem Date: Sat, 29 Sep 2007 23:32:15 +0200 Message-ID: <20070929213215.GB11774@saeurebad.de> References: <20070928143833.GC26384@saeurebad.de> <20070928154629.GA8089@saeurebad.de> <20070929212019.GA11774@saeurebad.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1707547136==" X-Trace: sea.gmane.org 1191101557 23522 80.91.229.12 (29 Sep 2007 21:32:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 29 Sep 2007 21:32:37 +0000 (UTC) To: Richard Stallman , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 29 23:32:33 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IbjvM-0004Th-SH for ged-emacs-devel@m.gmane.org; Sat, 29 Sep 2007 23:32:33 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IbjvJ-0004XZ-2H for ged-emacs-devel@m.gmane.org; Sat, 29 Sep 2007 17:32:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IbjvE-0004Tu-SZ for emacs-devel@gnu.org; Sat, 29 Sep 2007 17:32:24 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IbjvD-0004ST-QA for emacs-devel@gnu.org; Sat, 29 Sep 2007 17:32:24 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IbjvD-0004SM-NR for emacs-devel@gnu.org; Sat, 29 Sep 2007 17:32:23 -0400 Original-Received: from saeurebad.de ([85.214.36.134]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IbjvB-0005Dq-F0; Sat, 29 Sep 2007 17:32:21 -0400 Original-Received: by saeurebad.de (Postfix, from userid 1000) id E6C9A2F05A0; Sat, 29 Sep 2007 23:32:15 +0200 (CEST) Mail-Followup-To: Richard Stallman , emacs-devel@gnu.org In-Reply-To: <20070929212019.GA11774@saeurebad.de> User-Agent: Mutt/1.5.16 (2007-06-11) X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80027 Archived-At: --===============1707547136== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="aVD9QWMuhilNxW9f" Content-Disposition: inline --aVD9QWMuhilNxW9f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi again, On Sat, Sep 29, 2007 at 11:20:19PM +0200, Johannes Weiner wrote: > I think I have found the problem, please correct me if I am wrong: >=20 > Starting at lisp/faces.el, around the comment in line 1674. It says that= all > faces that should be NOT updated are collected (negative list, presuming = that > most faces should be updated and just to collect the ones that do not). >=20 > Now, I can not tell why the following happens since I am not into it very > deeply, but almost all faces, excluding about 4 here, are pushed to this > locally-modified list, which won't get updated through `face-spec-set' in= line > 1695. >=20 > The logic seems to be reversed; all faces that should get updated are left > untouched and vice versa. `locally-modified' contains exactly the opposi= te > set of items it should contain. I was lagging. If `face-spec-match-p' is t, then the face is already okay = and should not be updated and therefor be pushed to the list. (when (not (face-spec-match-p ...)) ...) is therefor wrong. It should be (when (face-spec-match-p ...) ...). Did I miss something? Hannes --=20 3BD8 AF56 11AF 205C 9DB6 B10F 76F1 0634 71A4 DCA0 --aVD9QWMuhilNxW9f Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFG/sRfdvEGNHGk3KARAk7gAJ4sg+tLcqgyJ824BbfdY7LcmdDCiACdFQeS Jvzfr59+clnfDp9e28sn56Q= =0xiQ -----END PGP SIGNATURE----- --aVD9QWMuhilNxW9f-- --===============1707547136== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --===============1707547136==--