From: Johannes Weiner <hannes@saeurebad.de>
To: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [BUG] Dark/bright face detection problem
Date: Sat, 29 Sep 2007 23:20:19 +0200 [thread overview]
Message-ID: <20070929212019.GA11774@saeurebad.de> (raw)
In-Reply-To: <E1Ibeu7-00087u-9n@fencepost.gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 1260 bytes --]
Hi,
On Sat, Sep 29, 2007 at 12:10:55PM -0400, Richard Stallman wrote:
> frame-set-background-mode should be called by setting the background color,
> and it ought to recompute all faces that are affected by the background mode.
>
> Can you please investigate what happens inside frame-set-background-mode
> so as to figure out the cause of this bug?
I think I have found the problem, please correct me if I am wrong:
Starting at lisp/faces.el, around the comment in line 1674. It says that all
faces that should be NOT updated are collected (negative list, presuming that
most faces should be updated and just to collect the ones that do not).
Now, I can not tell why the following happens since I am not into it very
deeply, but almost all faces, excluding about 4 here, are pushed to this
locally-modified list, which won't get updated through `face-spec-set' in line
1695.
The logic seems to be reversed; all faces that should get updated are left
untouched and vice versa. `locally-modified' contains exactly the opposite
set of items it should contain.
I will dig deeper into it, but for perhaps this already helps someone who
knows the code better.
Hannes
--
3BD8 AF56 11AF 205C 9DB6 B10F 76F1 0634 71A4 DCA0
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2007-09-29 21:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-28 14:38 [BUG] Dark/bright face detection problem Johannes Weiner
2007-09-28 15:46 ` Johannes Weiner
2007-09-29 16:10 ` Richard Stallman
2007-09-29 21:20 ` Johannes Weiner [this message]
2007-09-29 21:32 ` Johannes Weiner
[not found] ` <E1IbyK0-0005DQ-DU@fencepost.gnu.org>
2007-09-30 16:28 ` Problems with setting face attributes for specific frames Eli Zaretskii
2007-10-01 17:40 ` Richard Stallman
2007-09-30 23:54 ` Drew Adams
2007-10-01 17:40 ` Richard Stallman
2007-10-01 18:17 ` Drew Adams
2007-10-02 3:32 ` Richard Stallman
2007-10-02 15:09 ` Drew Adams
2007-10-02 22:00 ` Richard Stallman
2007-10-01 18:45 ` Stephen J. Turnbull
2007-10-02 3:32 ` Richard Stallman
2007-09-29 16:21 ` [BUG] Dark/bright face detection problem Dan Nicolaescu
2007-09-29 15:52 ` Eli Zaretskii
2007-09-29 16:16 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070929212019.GA11774@saeurebad.de \
--to=hannes@saeurebad.de \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).