From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: get rid of the MULTI_KBOARD #ifdefs Date: Tue, 25 Sep 2007 15:03:04 -0700 Message-ID: <200709252203.l8PM34cm003472@oogie-boogie.ics.uci.edu> References: <200709251640.l8PGeaeS020759@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1190757993 11194 80.91.229.12 (25 Sep 2007 22:06:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 25 Sep 2007 22:06:33 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 26 00:06:28 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IaIXw-0006kW-Pk for ged-emacs-devel@m.gmane.org; Wed, 26 Sep 2007 00:06:25 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IaIXt-0005bD-KC for ged-emacs-devel@m.gmane.org; Tue, 25 Sep 2007 18:06:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IaIXr-0005ay-BV for emacs-devel@gnu.org; Tue, 25 Sep 2007 18:06:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IaIXp-0005am-TT for emacs-devel@gnu.org; Tue, 25 Sep 2007 18:06:19 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IaIXp-0005aj-RS for emacs-devel@gnu.org; Tue, 25 Sep 2007 18:06:17 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IaIXk-0000sw-Us; Tue, 25 Sep 2007 18:06:13 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l8PM34cm003472; Tue, 25 Sep 2007 15:03:04 -0700 (PDT) In-Reply-To: (Eli Zaretskii's message of "Tue\, 25 Sep 2007 23\:36\:37 +0200") Original-Lines: 27 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-Detected-Kernel: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:79866 Archived-At: Eli Zaretskii writes: > > From: Dan Nicolaescu > > Date: Tue, 25 Sep 2007 09:40:36 -0700 > > > > So I think we should get rid of all the #ifdef MULTI_KBOARD > > conditionals and just leave the code for when MULTI_KBOARD is > > defined, this will help reduce the cruft in the code base. > > > > RMS OKed this provided there no objections here... > > > > Comments? > > The MSDOS port doesn't support MULTI_KBOARD (and never will). Have you made a decision yet if you still want to maintain the MSDOS port? > So if there's an alternative way of fixing this ugliness without > gratuitously breaking the DOS port, please use that alternative. AFAIK, now, the only big difference between MULTI_KBOARD and non MULTI_KBOARD is that in one case there a global variable of type struct kboard, and in the other case is malloced. So it seems to me that even if the MSDOS is kept alive, it might be possible to make it work in MULTI_KBOARD mode. But I don't have a good understanding about this, so take this with a big grain of salt...