From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: multi-tty breakage on MS-Windows Date: Sun, 09 Sep 2007 20:35:48 -0700 Message-ID: <200709100335.l8A3Zm2a010641@oogie-boogie.ics.uci.edu> References: <200709081532.l88FWcUu014489@oogie-boogie.ics.uci.edu> <200709081724.l88HO0Jd018184@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1189396290 27916 80.91.229.12 (10 Sep 2007 03:51:30 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 10 Sep 2007 03:51:30 +0000 (UTC) Cc: eliz@gnu.org, emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 10 13:51:16 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IUhaR-0002lS-Qx for ged-emacs-devel@m.gmane.org; Mon, 10 Sep 2007 13:37:52 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUa64-0008KY-PD for ged-emacs-devel@m.gmane.org; Sun, 09 Sep 2007 23:38:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IUa60-0008GR-Qb for emacs-devel@gnu.org; Sun, 09 Sep 2007 23:37:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IUa60-0008Fk-6C for emacs-devel@gnu.org; Sun, 09 Sep 2007 23:37:56 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUa60-0008Fb-2B for emacs-devel@gnu.org; Sun, 09 Sep 2007 23:37:56 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUa5s-00046W-4u; Sun, 09 Sep 2007 23:37:48 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l8A3Zm2a010641; Sun, 9 Sep 2007 20:35:49 -0700 (PDT) Original-Lines: 32 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-Detected-Kernel: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:78410 Archived-At: Richard Stallman writes: > The really bad problem is that lots of functions (in xterm.c, for > instance) have no comments. I don't know what they are supposed to > do. There must be some confusion here that it would be good if you could clarify: multi-tty only added 2 new functions to xterm.c. Only one of which does not have comments: x_create_terminal. But I doubt there can be any misunderstanding of what that function does. I added some comments to it, I'll commit it soon. Looking that the multi-tty diff for that file, most of the changes are because of adding another level of indirection, and using some new macros, not much new code added, and for the added code the comments added seem on par with what was there before. Or maybe you are referring to term.c, not xterm.c? 2 new functions there don't have much comments: set_tty_hooks and clear_tty_hooks, but they are pretty simple: what used to be global variables in term.c are now fields in struct terminal, those 2 functions set/reset those fields. I'll add some comments. There's a boatload of functions in term.c that don't have much comments, most of them are called tty_*. Maybe that is what you are referring to? The multi-tty patch renamed a lot of those functions, to start with "tty_", but it did not introduce them. Some of these functions have been around for at least 16 years, so I don't think you'd want multi-tty to document them. Anyway reverting the multi-tty patch as you said in another message will not help with that.