[Itai Seggev] Bug#439559: emacs22-gtk: forward/back buttons backwards when GTK is set to RTL language

[Itai Seggev] Bug#439559: emacs22-gtk: forward/back buttons backwards when GTK is set to RTL language

[Sven Joachim]

[-- Attachment #1: Type: text/plain, Size: 128 bytes --]

I received this via the Debian bug tracking system.  Could people who
have knowledge in GTK+ and/or Hebrew have a look at it?



[-- Attachment #2: Type: message/rfc822, Size: 5773 bytes --]

From: Itai Seggev <is+debian@cs.hmc.edu>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: Bug#439559: emacs22-gtk: forward/back buttons backwards when GTK is set to RTL language
Date: Sat, 25 Aug 2007 11:58:48 -0500
Message-ID: <20070825165848.15789.9099.reportbug@cavy>

Package: emacs22-gtk
Version: 22.1+1-1
Severity: normal
Tags: l10n

Emacs22 has these shiny new forward/back, next/previous, etc. buttons for
things like info mode. When using gtk Emacs, my menu bar goes from
right-to-left since my system locale is Hebrew. However, the back button still
points to the left. This results in the forward/back buttons pointing towards
each other rather than away from each other, which is very confusing. Either
the buttons should remain in the same left-to-right order always, or,
preferably, when in RTL mode the back button should point to the right and the
forward button should point to the left. 

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (110, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.21cavy1
Locale: LANG=he_IL.UTF-8, LC_CTYPE=he_IL.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages emacs22-gtk depends on:
ii  emacs22-bin-common      22.1+1-1         The GNU Emacs editor's shared, arc
ii  libasound2              1.0.14a-2        ALSA library
ii  libatk1.0-0             1.18.0-2         The ATK accessibility toolkit
ii  libc6                   2.6.1-1+b1       GNU C Library: Shared libraries
ii  libcairo2               1.4.10-1         The Cairo 2D vector graphics libra
ii  libfontconfig1          2.4.2-1.2        generic font configuration library
ii  libglib2.0-0            2.14.0-2         The GLib library of C routines
ii  libgtk2.0-0             2.10.13-1        The GTK+ graphical user interface 
ii  libice6                 2:1.0.3-3        X11 Inter-Client Exchange library
ii  libjpeg62               6b-13            The Independent JPEG Group's JPEG 
ii  libncurses5             5.6+20070812-1   Shared libraries for terminal hand
ii  libpango1.0-0           1.16.5-1         Layout and rendering of internatio
ii  libpng12-0              1.2.15~beta5-2   PNG library - runtime
ii  libsm6                  2:1.0.3-1+b1     X11 Session Management library
ii  libtiff4                3.8.2-7          Tag Image File Format (TIFF) libra
ii  libungif4g              4.1.4-5          shared library for GIF images
ii  libx11-6                2:1.0.3-7        X11 client-side library
ii  libxcursor1             1:1.1.8-2        X cursor management library
ii  libxext6                1:1.0.3-2        X11 miscellaneous extension librar
ii  libxfixes3              1:4.0.3-2        X11 miscellaneous 'fixes' extensio
ii  libxft2                 2.1.12-2         FreeType-based font drawing librar
ii  libxi6                  2:1.1.2-1        X11 Input extension library
ii  libxinerama1            1:1.0.2-1        X11 Xinerama extension library
ii  libxpm4                 1:3.5.6-3        X11 pixmap library
ii  libxrandr2              2:1.2.1-1        X11 RandR extension library
ii  libxrender1             1:0.9.2-1        X Rendering Extension client libra
ii  zlib1g                  1:1.2.3.3.dfsg-5 compression library - runtime

emacs22-gtk recommends no packages.

-- no debconf information



[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: [Itai Seggev] Bug#439559: emacs22-gtk: forward/back buttons backwards when GTK is set to RTL language

[Jan Djärv]

Itai Seggev skrev:
> On Tue, Aug 28, 2007 at 12:19:43PM +0200, Jan Djärv wrote:
>> I've made a fix in CVS HEAD, can you try that?
> 
> OK, I've downloaded and compiled CVS HEAD. After about 2 minutes of
> testing, it seems that the next-node/previous-node buttons are
> correctly ordered for a RTL language, but that
> forward-history/back-history are still in the LTR orientation. I'll
> play some more with it after work and see if there are any additional issues.

It seems that some themes don't supply RTL information.  Can you try some 
other themes and see if the forward-history/back-history are correct for any 
of them?  Crux, Bluecurve or Clearlooks works for me.

> 
>> As the change is a bit large, I am reluctant to put this into Emacs 22.  Is 
>> forcing the tool bar to left-to-right OK there?
> 
> I'd like to see this in action before I give a definite answer (also,
> I don't know how long Emacs 22 will be with us. If it's another 6
> years, then...) but I think as interim solution this would be fine. 

Well, it would look like a "normal" tool bar, like the one you get with locale 
"C".

	Jan D.

Re: [Itai Seggev] Bug#439559: emacs22-gtk: forward/back buttons backwards when GTK is set to RTL language

[Itai Seggev]

On Thu, Aug 30, 2007 at 08:10:26AM +0200, Jan Djärv wrote:
> 
> 
> Itai Seggev skrev:
> >On Tue, Aug 28, 2007 at 12:19:43PM +0200, Jan Djärv wrote:
> >>I've made a fix in CVS HEAD, can you try that?
> >
> >OK, I've downloaded and compiled CVS HEAD. After about 2 minutes of
> >testing, it seems that the next-node/previous-node buttons are
> >correctly ordered for a RTL language, but that
> >forward-history/back-history are still in the LTR orientation. I'll
> >play some more with it after work and see if there are any additional 
> >issues.
> 
> It seems that some themes don't supply RTL information.  Can you try some 
> other themes and see if the forward-history/back-history are correct for 
> any of them?  Crux, Bluecurve or Clearlooks works for me.

OK, so it is a problem with some themes and not others. In particular with
gtk-qt. However, if the problem really is with the theme, why is it
that the next/previous buttons are OK, and only the back/forward
buttons don't look right. Perhaps whatever changes to next/previous
could also be applied to forward/back so that they also look OK in all
themes. 

> 
> Well, it would look like a "normal" tool bar, like the one you get with 
> locale "C".

So the menu bar would the RTL, but the toolbar would be LTR? That's a
bit wiered, but I guess better than the current situation. 
--
Itai

Itai Seggev, Knox College, Mathematics Department 

In 1997 a group of programmers started writing a desktop environment
to fix a travesty they didn't create.  Their program promptly found
its way onto un*x systems everywhere. Today, still opposed by a
software monopolist, they survive as soldiers of fortune.  If you share
their vision, if you know you can help, and if you can connect to
internet, maybe you can join... the K-Team.

Re: [Itai Seggev] Bug#439559: emacs22-gtk: forward/back buttons backwards when GTK is set to RTL language

[Jan Djärv]

Itai Seggev skrev:
> On Thu, Aug 30, 2007 at 08:10:26AM +0200, Jan Djärv wrote:
>>
>> Itai Seggev skrev:
>>> On Tue, Aug 28, 2007 at 12:19:43PM +0200, Jan Djärv wrote:
>>>> I've made a fix in CVS HEAD, can you try that?
>>> OK, I've downloaded and compiled CVS HEAD. After about 2 minutes of
>>> testing, it seems that the next-node/previous-node buttons are
>>> correctly ordered for a RTL language, but that
>>> forward-history/back-history are still in the LTR orientation. I'll
>>> play some more with it after work and see if there are any additional 
>>> issues.
>> It seems that some themes don't supply RTL information.  Can you try some 
>> other themes and see if the forward-history/back-history are correct for 
>> any of them?  Crux, Bluecurve or Clearlooks works for me.
> 
> OK, so it is a problem with some themes and not others. In particular with
> gtk-qt. However, if the problem really is with the theme, why is it
> that the next/previous buttons are OK, and only the back/forward
> buttons don't look right. Perhaps whatever changes to next/previous
> could also be applied to forward/back so that they also look OK in all
> themes. 

The difference is that next/previous are not Gtk+ stock icons (i.e. defined by 
the theme), but forward/back are.  Gtk+ handles RTL/LTR by itself when stock 
icons are used, but only if the theme supplies that information.

So in theory we should ask Gtk+ if RTL is used, and if so, does the stock 
icons have any RTL information?  Unfortunately, the Gtk+ API does not give us 
access to RTL information for individual themed icons.  So sometimes Gtk+ does 
the right thing, sometimes it does not, depending on the theme used.

We could "untheme" forward/back, but that would be too drastic.  The best I 
can think of for your situation is to

a) file a bug report on the theme you are using.  The root cuase is there.

b) As a workaround, you can "untheme" forward/back by customizing 
x-gtk-stock-map (M-x customize-variable<RET>x-gtk-stock-map<RET>).
Delete the rows for etc/images/left-arrow and etc/images/right-arrow.  The 
downside is that forward/back are now not themed.  But all themes will be 
correct RTL-wise.

c) You can also swap icons in x-gtk-stock-map, so you map 
etc/images/left-arrow to gtk-go-forward and etc/images/right-arrow to 
gtk-go-back.  But remember that you did this if you change theme or your theme 
is fixed so that it supplies RTL information.

> 
>> Well, it would look like a "normal" tool bar, like the one you get with 
>> locale "C".
> 
> So the menu bar would the RTL, but the toolbar would be LTR? That's a
> bit wiered, but I guess better than the current situation. 

Emacs 22 and emacs CVS HEAD now behave the same in this regard, so forcing LTR 
is not an option anymore.

	Jan D.