From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "d.henman" Newsgroups: gmane.emacs.devel Subject: Re: Failure in building Emacs 23.0.50 on Cygwin Date: Sat, 01 Sep 2007 19:14:15 +0900 Message-ID: <20070901191415.3788@blackhawk> References: <20070901091956.1876@blackhawk> <200709010035.l810Zwni021513@oogie-boogie.ics.uci.edu> <20070901125313.1488@blackhawk> NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1188641480 30240 80.91.229.12 (1 Sep 2007 10:11:20 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 1 Sep 2007 10:11:20 +0000 (UTC) Cc: dann@ics.uci.edu, "d. henman" , emacs-devel@gnu.org To: "Eli Zaretskii" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 01 12:11:15 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IRPwe-0007dQ-Rn for ged-emacs-devel@m.gmane.org; Sat, 01 Sep 2007 12:11:13 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IRPwd-00083j-S2 for ged-emacs-devel@m.gmane.org; Sat, 01 Sep 2007 06:11:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IRPwZ-00081F-Kx for emacs-devel@gnu.org; Sat, 01 Sep 2007 06:11:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IRPwX-0007w3-No for emacs-devel@gnu.org; Sat, 01 Sep 2007 06:11:06 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IRPwX-0007va-Fk for emacs-devel@gnu.org; Sat, 01 Sep 2007 06:11:05 -0400 Original-Received: from mail2.asahi-net.or.jp ([202.224.39.198] helo=mail.asahi-net.or.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IRPwU-0007MQ-3N; Sat, 01 Sep 2007 06:11:02 -0400 Original-Received: from blackhawk (p046236.ppp.asahi-net.or.jp [221.113.46.236]) by mail.asahi-net.or.jp (Postfix) with ESMTP id 6BD50107C6C; Sat, 1 Sep 2007 19:11:01 +0900 (JST) In-reply-to: Your message of Sat, 01 Sep 2007 11:18:08 +0300 X-Mailer: MH-E 8.0.3; GNU Mailutils 1.2.1; GNU Emacs 22.1.50 X-Detected-Kernel: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:77540 Archived-At: I also feel that defining a "croak" for cygwin and all other platforms in sysdep.c is a better one. After all that is what sysdep.c is for, I should think... But, I don't have sufficient knowledge at this point, other thatn to make it functionwith no processing thet simply returns a zero, for o.k. Regards, Darel Henman Eli Zaretskii wrote: > > From: "d.henman" > > Date: Sat, 01 Sep 2007 12:53:13 +0900 > > Cc: emacs-devel@gnu.org > > > > --- term.c 2007-08-30 06:46:50.000000000 +0900 > > +++ term.c.fixed 2007-09-01 10:39:51.906250000 +0900 > > @@ -3142,8 +3142,10 @@ > > emacs_close (fd); > > sigunblock (sigmask (SIGTTOU)); > > #else > > +#ifndef CYGWIN > > /* Unknown system. */ > > croak (); > > +#endif /* ! CYGWIN */ > > #endif /* ! TIOCNOTTY */ > > #endif /* ! USG */ > > } > > > > --=-=-= > > > > > > Please review this and let me know if I can check it into cvs. > > Please don't, as I think it;s the wrong way of fixing the problem. > > I think the idea of defining `croak' for all platforms in sysdep.c is > a better one.