From: "d.henman" <dhenman@gmail.com>
To: "Eli Zaretskii" <eliz@gnu.org>
Cc: dann@ics.uci.edu, "d. henman" <dhenman@gmail.com>, emacs-devel@gnu.org
Subject: Re: Failure in building Emacs 23.0.50 on Cygwin
Date: Sat, 01 Sep 2007 19:14:15 +0900 [thread overview]
Message-ID: <20070901191415.3788@blackhawk> (raw)
In-Reply-To: Your message of Sat, 01 Sep 2007 11:18:08 +0300 <ur6livlxb.fsf@gnu.org>
I also feel that defining a "croak" for cygwin and all other platforms in sysdep.c is
a better one.
After all that is what sysdep.c is for, I should think...
But, I don't have sufficient knowledge at this point, other thatn to make it functionwith no processing thet simply returns a zero, for o.k.
Regards,
Darel Henman
Eli Zaretskii <eliz@gnu.org> wrote:
> > From: "d.henman" <dhenman@gmail.com>
> > Date: Sat, 01 Sep 2007 12:53:13 +0900
> > Cc: emacs-devel@gnu.org
> >
> > --- term.c 2007-08-30 06:46:50.000000000 +0900
> > +++ term.c.fixed 2007-09-01 10:39:51.906250000 +0900
> > @@ -3142,8 +3142,10 @@
> > emacs_close (fd);
> > sigunblock (sigmask (SIGTTOU));
> > #else
> > +#ifndef CYGWIN
> > /* Unknown system. */
> > croak ();
> > +#endif /* ! CYGWIN */
> > #endif /* ! TIOCNOTTY */
> > #endif /* ! USG */
> > }
> >
> > --=-=-=
> >
> >
> > Please review this and let me know if I can check it into cvs.
>
> Please don't, as I think it;s the wrong way of fixing the problem.
>
> I think the idea of defining `croak' for all platforms in sysdep.c is
> a better one.
next prev parent reply other threads:[~2007-09-01 10:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-29 23:51 Failure in building Emacs 23.0.50 on Cygwin Angelo Graziosi
2007-08-30 0:56 ` Dan Nicolaescu
2007-08-30 23:42 ` Angelo Graziosi
2007-09-01 0:19 ` d.henman
2007-09-01 0:35 ` Dan Nicolaescu
2007-09-01 3:53 ` d.henman
2007-09-01 8:18 ` Eli Zaretskii
2007-09-01 10:14 ` d.henman [this message]
2007-09-01 10:36 ` Eli Zaretskii
2007-09-01 16:10 ` Dan Nicolaescu
2007-09-01 8:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070901191415.3788@blackhawk \
--to=dhenman@gmail.com \
--cc=dann@ics.uci.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).