From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Failure in building Emacs 23.0.50 on Cygwin Date: Sat, 01 Sep 2007 09:10:39 -0700 Message-ID: <200709011610.l81GAdCe013060@oogie-boogie.ics.uci.edu> References: <20070901091956.1876@blackhawk> <200709010035.l810Zwni021513@oogie-boogie.ics.uci.edu> <20070901125313.1488@blackhawk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1188663187 23774 80.91.229.12 (1 Sep 2007 16:13:07 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 1 Sep 2007 16:13:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: "d.henman" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 01 18:13:06 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IRVar-00008U-04 for ged-emacs-devel@m.gmane.org; Sat, 01 Sep 2007 18:13:05 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IRVap-0004SA-Rc for ged-emacs-devel@m.gmane.org; Sat, 01 Sep 2007 12:13:03 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IRVam-0004Rd-8B for emacs-devel@gnu.org; Sat, 01 Sep 2007 12:13:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IRVal-0004Qe-2Q for emacs-devel@gnu.org; Sat, 01 Sep 2007 12:12:59 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IRVak-0004Qa-P5 for emacs-devel@gnu.org; Sat, 01 Sep 2007 12:12:58 -0400 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IRVak-0007Cv-DL for emacs-devel@gnu.org; Sat, 01 Sep 2007 12:12:58 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id l81GAdCe013060; Sat, 1 Sep 2007 09:10:39 -0700 (PDT) In-Reply-To: <20070901125313.1488@blackhawk> (d. henman's message of "Sat\, 01 Sep 2007 12\:53\:13 +0900") Original-Lines: 39 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-Detected-Kernel: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:77546 Archived-At: "d.henman" writes: > Dan Nicolaescu wrote: > > IMO the question should be asked the other way: how do you avoid > > references to "croak". > > > > Adjust preprocessor code in dissociate_if_controlling_tty so that > > croak is not used. Whether that is enough to make cygwin work, I don't > > know. > > Here is the patch I came up with to avoid a reference to croak on the > cygwin platform. > > > --- term.c 2007-08-30 06:46:50.000000000 +0900 > +++ term.c.fixed 2007-09-01 10:39:51.906250000 +0900 > @@ -3142,8 +3142,10 @@ > emacs_close (fd); > sigunblock (sigmask (SIGTTOU)); > #else > +#ifndef CYGWIN > /* Unknown system. */ > croak (); > +#endif /* ! CYGWIN */ > #endif /* ! TIOCNOTTY */ > #endif /* ! USG */ > } > > > Please review this and let me know if I can check it into cvs. So In evect you are making dissociate_if_controlling_tty be an empty function on cygwin. Is that the right thing to do for this platform? If it is, then I think it would be cleaner to change #ifdef WINDOWSNT to #if defined(WINDOWSNT) || defined(CYGWIN) (BTW, does emacs work on cygwin after your patch?)