Re: Failure in building Emacs 23.0.50 on Cygwin

[Dan Nicolaescu <dann@ics.uci.edu>]

"d.henman" <dhenman@gmail.com> writes:

  > Dan Nicolaescu <dann@ics.uci.edu> wrote:
  > > IMO the question should be asked the other way: how do you avoid
  > > references to "croak". 
  > > 
  > > Adjust preprocessor code in dissociate_if_controlling_tty so that
  > > croak is not used. Whether that is enough to make cygwin work, I don't
  > > know. 
  > 
  > Here is the patch I came up with to avoid a reference to croak on the
  > cygwin platform.
  > 
  > 
  > --- term.c	2007-08-30 06:46:50.000000000 +0900
  > +++ term.c.fixed	2007-09-01 10:39:51.906250000 +0900
  > @@ -3142,8 +3142,10 @@
  >          emacs_close (fd);
  >        sigunblock (sigmask (SIGTTOU));
  >  #else
  > +#ifndef CYGWIN
  >        /* Unknown system. */
  >        croak ();
  > +#endif  /* ! CYGWIN */
  >  #endif  /* ! TIOCNOTTY */
  >  #endif  /* ! USG */
  >      }
  > 
  > 
  > Please review this and let me know if I can check it into cvs.

So In evect you are making dissociate_if_controlling_tty be an empty
function on cygwin. Is that the right thing to do for this platform?
If it is, then I think it would be cleaner to change
#ifdef WINDOWSNT 
to 
#if defined(WINDOWSNT) || defined(CYGWIN)

(BTW, does emacs work on cygwin after your patch?)