Failure in building Emacs 23.0.50 on Cygwin

Failure in building Emacs 23.0.50 on Cygwin

[Angelo Graziosi]

I have tried to bootstrap the last Emacs-23.0.50 CVS (checked out about an
hour ago) on Cygwin, but it fails:

---------------------------------------------------------------
Configuring...
checking build system type... i686-pc-cygwin
checking host system type... i686-pc-cygwin
checking for gcc... gcc
checking for C compiler default output file name... a.exe
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... .exe
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for AIX... no
checking whether gcc understands -Wno-pointer-sign... yes
checking whether ln -s works... yes
checking how to run the C preprocessor... gcc -E
checking for a BSD-compatible install... /usr/bin/install -c
checking for ranlib... ranlib
checking for install-info... /usr/bin/install-info
checking for install-info... (cached) /usr/bin/install-info
checking for install-info... (cached) /usr/bin/install-info
checking for gzip... /usr/bin/gzip
checking for makeinfo... /usr/bin/makeinfo
checking for -znocombreloc... no
configure: checking the machine- and system-dependent files to find out
 - which libraries the lib-src programs will want, and
 - whether the GNU malloc routines are usable...
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... no
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking machine/soundcard.h usability... no
checking machine/soundcard.h presence... no
checking for machine/soundcard.h... no
checking sys/soundcard.h usability... yes
checking sys/soundcard.h presence... yes
checking for sys/soundcard.h... yes
checking soundcard.h usability... no
checking soundcard.h presence... no
checking for soundcard.h... no
checking for _oss_ioctl in -lossaudio... no
checking for pkg-config... /usr/bin/pkg-config
checking for alsa >= 1.0.0... no
checking sys/select.h usability... yes
checking sys/select.h presence... yes
checking for sys/select.h... yes
checking sys/timeb.h usability... yes
checking sys/timeb.h presence... yes
checking for sys/timeb.h... yes
checking sys/time.h usability... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking for unistd.h... (cached) yes
checking utime.h usability... yes
checking utime.h presence... yes
checking for utime.h... yes
checking linux/version.h usability... no
checking linux/version.h presence... no
checking for linux/version.h... no
checking sys/systeminfo.h usability... no
checking sys/systeminfo.h presence... no
checking for sys/systeminfo.h... no
checking termios.h usability... yes
checking termios.h presence... yes
checking for termios.h... yes
checking limits.h usability... yes
checking limits.h presence... yes
checking for limits.h... yes
checking for string.h... (cached) yes
checking for stdlib.h... (cached) yes
checking termcap.h usability... yes
checking termcap.h presence... yes
checking for termcap.h... yes
checking stdio_ext.h usability... no
checking stdio_ext.h presence... no
checking for stdio_ext.h... no
checking fcntl.h usability... yes
checking fcntl.h presence... yes
checking for fcntl.h... yes
checking for strings.h... (cached) yes
checking coff.h usability... no
checking coff.h presence... no
checking for coff.h... no
checking pty.h usability... yes
checking pty.h presence... yes
checking for pty.h... yes
checking sys/mman.h usability... yes
checking sys/mman.h presence... yes
checking for sys/mman.h... yes
checking sys/param.h usability... yes
checking sys/param.h presence... yes
checking for sys/param.h... yes
checking sys/vlimit.h usability... no
checking sys/vlimit.h presence... no
checking for sys/vlimit.h... no
checking sys/resource.h usability... yes
checking sys/resource.h presence... yes
checking for sys/resource.h... yes
checking locale.h usability... yes
checking locale.h presence... yes
checking for locale.h... yes
checking sys/_mbstate_t.h usability... no
checking sys/_mbstate_t.h presence... no
checking for sys/_mbstate_t.h... no
checking sys/utsname.h usability... yes
checking sys/utsname.h presence... yes
checking for sys/utsname.h... yes
checking pwd.h usability... yes
checking pwd.h presence... yes
checking for pwd.h... yes
checking if personality LINUX32 can be set... no
checking for term.h... no
checking for ANSI C header files... (cached) yes
checking whether time.h and sys/time.h may both be included... yes
checking whether sys_siglist is declared... no
checking whether __sys_siglist is declared... no
checking for sys/wait.h that is POSIX.1 compatible... yes
checking for struct utimbuf... yes
checking return type of signal handlers... void
checking for speed_t... yes
checking for struct timeval... yes
checking for struct exception... yes
checking sys/socket.h usability... yes
checking sys/socket.h presence... yes
checking for sys/socket.h... yes
checking for net/if.h... yes
checking whether struct tm is in sys/time.h or time.h... time.h
checking for struct tm.tm_zone... no
checking whether tzname is declared... yes
checking for tzname... yes
checking for struct tm.tm_gmtoff... no
checking for struct ifreq.ifr_flags... yes
checking for struct ifreq.ifr_hwaddr... yes
checking for struct ifreq.ifr_netmask... yes
checking for struct ifreq.ifr_broadaddr... yes
checking for struct ifreq.ifr_addr... yes
checking for function prototypes... yes
checking for working volatile... yes
checking for an ANSI C-conforming const... yes
checking for void * support... yes
checking whether make sets $(MAKE)... yes
checking for long file names... yes
checking for X... libraries /usr/X11R6/lib, headers /usr/X11R6/include
checking Carbon/Carbon.h usability... no
checking Carbon/Carbon.h presence... no
checking for Carbon/Carbon.h... no
checking for malloc_get_state... no
checking for malloc_set_state... no
checking whether __after_morecore_hook exists... no
checking for stdlib.h... (cached) yes
checking for unistd.h... (cached) yes
checking for getpagesize... yes
checking for working mmap... no
checking for dnet_ntoa in -ldnet... no
checking for main in -lXbsd... no
checking for cma_open in -lpthreads... no
checking for XFree86 in /usr/X386... no
checking for Xkb... yes
checking for XrmSetDatabase... yes
checking for XScreenResourceString... yes
checking for XScreenNumberOfScreen... yes
checking for XSetWMProtocols... yes
checking X11 version 6... 6 or newer
checking X11 version 5... 5 or newer
checking for librsvg-2.0 >= 2.0.0... no
checking for xaw3d... yes; using Lucid toolkit
checking X11 toolkit version... 6 or newer
checking for XmuConvertStandardSelection in -lXmu... yes
checking for XShapeQueryExtension in -lXext... yes
checking X11/xpm.h usability... yes
checking X11/xpm.h presence... yes
checking for X11/xpm.h... yes
checking for XpmReadFileToPixmap in -lXpm... yes
checking for XpmReturnAllocPixels preprocessor define... yes
checking jerror.h usability... yes
checking jerror.h presence... yes
checking for jerror.h... yes
checking for jpeg_destroy_compress in -ljpeg... yes
checking png.h usability... yes
checking png.h presence... yes
checking for png.h... yes
checking libpng/png.h usability... yes
checking libpng/png.h presence... yes
checking for libpng/png.h... yes
checking for png_get_channels in -lpng... yes
checking tiffio.h usability... yes
checking tiffio.h presence... yes
checking for tiffio.h... yes
checking for TIFFGetVersion in -ltiff... yes
checking gif_lib.h usability... yes
checking gif_lib.h presence... yes
checking for gif_lib.h... yes
checking for EGifPutExtensionLast in -lgif... no
checking for EGifPutExtensionLast in -lungif... yes
checking gpm.h usability... no
checking gpm.h presence... no
checking for gpm.h... no
checking malloc/malloc.h usability... no
checking malloc/malloc.h presence... no
checking for malloc/malloc.h... no
checking X11/SM/SMlib.h usability... yes
checking X11/SM/SMlib.h presence... yes
checking for X11/SM/SMlib.h... yes
checking for SmcOpenConnection in -lSM... yes
checking whether netdb declares h_errno... yes
checking for working alloca.h... yes
checking for alloca... yes
checking for sqrt in -lm... yes
checking for maillock in -lmail... no
checking for maillock in -llockfile... no
checking for liblockfile.so... no
checking for touchlock... no
checking maillock.h usability... no
checking maillock.h presence... no
checking for maillock.h... no
checking for gethostname... yes
checking for getdomainname... yes
checking for dup2... yes
checking for rename... yes
checking for closedir... yes
checking for mkdir... yes
checking for rmdir... yes
checking for sysinfo... no
checking for getrusage... yes
checking for get_current_dir_name... no
checking for random... yes
checking for lrand48... yes
checking for bcopy... yes
checking for bcmp... yes
checking for logb... yes
checking for frexp... yes
checking for fmod... yes
checking for rint... yes
checking for cbrt... yes
checking for ftime... yes
checking for res_init... no
checking for setsid... yes
checking for strerror... yes
checking for fpathconf... yes
checking for select... yes
checking for mktime... yes
checking for euidaccess... no
checking for getpagesize... (cached) yes
checking for tzset... yes
checking for setlocale... yes
checking for utimes... yes
checking for setrlimit... yes
checking for setpgid... yes
checking for getcwd... yes
checking for getwd... yes
checking for shutdown... yes
checking for getaddrinfo... no
checking for __fpending... no
checking for mblen... yes
checking for mbrlen... yes
checking for mbsinit... yes
checking for strsignal... yes
checking for setitimer... yes
checking for ualarm... yes
checking for index... yes
checking for rindex... yes
checking for sendto... yes
checking for recvfrom... yes
checking for getsockopt... yes
checking for setsockopt... yes
checking for getsockname... yes
checking for getpeername... yes
checking for gai_strerror... no
checking for mkstemp... yes
checking for getline... yes
checking for getdelim... yes
checking for mremap... no
checking for memmove... yes
checking for fsync... yes
checking for sync... yes
checking for bzero... yes
checking for memset... yes
checking for memcmp... yes
checking for difftime... yes
checking for memcpy... yes
checking for mempcpy... yes
checking for mblen... (cached) yes
checking for mbrlen... (cached) yes
checking for posix_memalign... no
checking sys/un.h usability... yes
checking sys/un.h presence... yes
checking for sys/un.h... yes
checking for sys/time.h... (cached) yes
checking for unistd.h... (cached) yes
checking for alarm... yes
checking for working mktime... no
checking for getloadavg... no
checking for pstat_getdynamic... no
checking for kstat_open in -lkstat... no
checking for elf_begin in -lelf... no
checking for kvm_open in -lkvm... no
checking for getloadavg in -lutil... no
checking for getloadavg in -lgetloadavg... no
checking for getloadavg... no
checking sys/dg_sys_info.h usability... no
checking sys/dg_sys_info.h presence... no
checking for sys/dg_sys_info.h... no
checking for locale.h... (cached) yes
checking for setlocale... (cached) yes
checking inq_stats/cpustats.h usability... no
checking inq_stats/cpustats.h presence... no
checking for inq_stats/cpustats.h... no
checking sys/cpustats.h usability... no
checking sys/cpustats.h presence... no
checking for sys/cpustats.h... no
checking mach/mach.h usability... no
checking mach/mach.h presence... no
checking for mach/mach.h... no
checking nlist.h usability... no
checking nlist.h presence... no
checking for nlist.h... no
checking whether getloadavg requires setgid... no
checking for _LARGEFILE_SOURCE value needed for large files... no
checking getopt.h usability... yes
checking getopt.h presence... yes
checking for getopt.h... yes
checking for getopt_long_only... yes
checking whether optreset is declared... yes
checking whether getpgrp requires zero arguments... yes
checking for strftime... yes
checking for grantpt... yes
checking for getpt... no
checking for tparm in -lncurses... yes
checking for dgettext in -lintl... yes
checking whether localtime caches TZ... no
checking for gettimeofday... yes
checking whether gettimeofday can accept two arguments... yes
checking for socket... yes
checking netinet/in.h usability... yes
checking netinet/in.h presence... yes
checking for netinet/in.h... yes
checking arpa/inet.h usability... yes
checking arpa/inet.h presence... yes
checking for arpa/inet.h... yes
checking sys/ioctl.h usability... yes
checking sys/ioctl.h presence... yes
checking for sys/ioctl.h... yes
checking whether system supports dynamic ptys... no
checking for pid_t... yes
checking vfork.h usability... no
checking vfork.h presence... no
checking for vfork.h... no
checking for fork... yes
checking for vfork... yes
checking for working fork... yes
checking for working vfork... (cached) yes
checking for nl_langinfo and CODESET... yes
checking for size_t... yes
checking for mbstate_t... yes
checking for C restrict keyword... __restrict
checking for C restricted array declarations... yes

Configured for `i686-pc-cygwin'.

  Where should the build process find the source code?
/tmp/emacs-23.0.50
  What operating system and machine description files should Emacs use?
        `s/cygwin.h' and `m/intel386.h'
  What compiler should emacs be built with?               gcc -g -O2
-Wno-pointer-sign
  Should Emacs use the GNU version of malloc?             yes
  Should Emacs use a relocating allocator for buffers?    yes
  Should Emacs use mmap(2) for buffer allocation?         no
  What window system should Emacs use?                    x11
  What toolkit should Emacs use?                          LUCID
  Where do we find X Windows header files?
/usr/X11R6/include
  Where do we find X Windows libraries?                   /usr/X11R6/lib
  Does Emacs use -lXaw3d?                                 yes
  Does Emacs use -lXpm?                                   yes
  Does Emacs use -ljpeg?                                  yes
  Does Emacs use -ltiff?                                  yes
  Does Emacs use a gif library?                           yes -lungif
  Does Emacs use -lpng?                                   yes
  Does Emacs use -lrsvg-2?                                no
  Does Emacs use -lgpm?                                   no
  Does Emacs use X toolkit scroll bars?                   yes

configure: creating ./config.status
config.status: creating Makefile
config.status: creating lib-src/Makefile.c
config.status: creating oldXMenu/Makefile
config.status: creating man/Makefile
config.status: creating lwlib/Makefile
config.status: creating src/Makefile.c
config.status: creating lisp/Makefile
config.status: creating lispref/Makefile
config.status: creating lispintro/Makefile
config.status: creating leim/Makefile
config.status: creating src/config.h
config.status: executing default commands
creating src/epaths.h
creating lib-src/Makefile
creating src/Makefile
creating src/.gdbinit

cd lib-src; make all  \
	  CC='gcc' CFLAGS='-g -O2 -Wno-pointer-sign ' CPPFLAGS='' \
	  LDFLAGS='-Wl,--enable-auto-import -Wl,--enable-auto-image-base
-L/usr/X11R6/lib' MAKE='make'
make[1]: Entering directory `/tmp/emacs-23.0.50/build/lib-src'
gcc -DHAVE_CONFIG_H -I. -I../src -I/tmp/emacs-23.0.50/lib-src
-I/tmp/emacs-23.0.50/lib-src/../src -Wl,--enable-auto-import
-Wl,--enable-auto-image-base -L/usr/X11R6/lib  -g -O2 -Wno-pointer-sign
-o test-distrib /tmp/emacs-23.0.50/lib-src/test-distrib.c

 ...

gcc -c -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. -I/tmp/emacs/src
-I/usr/X11R6/include   -g -O2 -Wno-pointer-sign  /tmp/emacs/src/widget.c
gcc -c  -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. -I/tmp/emacs/src
-I/usr/X11R6/include   -g -O2 -Wno-pointer-sign  /tmp/emacs/src/mktime.c
gcc -c  -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. -I/tmp/emacs/src
-I/usr/X11R6/include   -g -O2 -Wno-pointer-sign
/tmp/emacs/src/getloadavg.c
gcc -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. -I/tmp/emacs/src
-I/usr/X11R6/include   -g -O2 -Wno-pointer-sign  -Wl,--enable-auto-import
-Wl,--enable-auto-image-base -L/usr/X11R6/lib /tmp/emacs/src/prefix-args.c
-o prefix-args
echo "dispnew.o frame.o scroll.o xdisp.o xmenu.o window.o charset.o
coding.o category.o ccl.o cm.o term.o terminal.o xfaces.o xterm.o xfns.o
xselect.o xrdb.o fontset.o xsmfns.o fringe.o image.o  emacs.o keyboard.o
macros.o keymap.o sysdep.o buffer.o filelock.o insdel.o marker.o minibuf.o
fileio.o dired.o filemode.o cmds.o casetab.o casefiddle.o indent.o
search.o regex.o undo.o alloc.o data.o doc.o editfns.o callint.o eval.o
floatfns.o fns.o print.o lread.o abbrev.o syntax.o unexcw.o bytecode.o
process.o callproc.o region-cache.o sound.o atimer.o doprnt.o strftime.o
intervals.o textprop.o composite.o md5.o   sheap.o terminfo.o gmalloc.o
ralloc.o lastfile.o vm-limit.o  widget.o mktime.o getloadavg.o " >
buildobj.lst
gcc   -Wl,--enable-auto-import -Wl,--enable-auto-image-base
-L/usr/X11R6/lib -o temacs ecrt0.o dispnew.o frame.o scroll.o xdisp.o
xmenu.o window.o charset.o coding.o category.o ccl.o cm.o term.o
terminal.o xfaces.o xterm.o xfns.o xselect.o xrdb.o fontset.o xsmfns.o
fringe.o image.o  emacs.o keyboard.o macros.o keymap.o sysdep.o buffer.o
filelock.o insdel.o marker.o minibuf.o fileio.o dired.o filemode.o cmds.o
casetab.o casefiddle.o indent.o search.o regex.o undo.o alloc.o data.o
doc.o editfns.o callint.o eval.o floatfns.o fns.o print.o lread.o abbrev.o
syntax.o unexcw.o bytecode.o process.o callproc.o region-cache.o sound.o
atimer.o doprnt.o strftime.o intervals.o textprop.o composite.o md5.o
sheap.o terminfo.o gmalloc.o ralloc.o lastfile.o vm-limit.o  widget.o
mktime.o getloadavg.o   ../lwlib/liblw.a -L/usr/X11R6/lib -lXaw3d -lXmu
-lXt -lSM -lICE -lXext -ltiff -ljpeg -lpng -lz -lm -lungif -lXpm -lX11
-lcurses -lg  `gcc -print-libgcc-file-name` -lm -lc `gcc
-print-libgcc-file-name`
term.o: In function `dissociate_if_controlling_tty':
/tmp/emacs/src/term.c:3146: undefined reference to `_croak'
collect2: ld returned 1 exit status
make[2]: *** [temacs.exe] Error 1
make[2]: Leaving directory `/tmp/emacs/build/src'
make[1]: *** [bootstrap-build] Error 2
make[1]: Leaving directory `/tmp/emacs/build'
make: *** [bootstrap] Error 2
---------------------------------------------------------------

(Note that term.c was one of the last update files before I checked out
CVS)


The same CVS bootstraps fine on GNU/Linux SLC4.


The CVS of 20070819 builds fine on both systems (linux and cygwin)



Cheers,

   Angelo.

Re: Failure in building Emacs 23.0.50 on Cygwin

[Dan Nicolaescu]

Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:

  > I have tried to bootstrap the last Emacs-23.0.50 CVS (checked out about an
  > hour ago) on Cygwin, but it fails:

[snip]  

  > gcc   -Wl,--enable-auto-import -Wl,--enable-auto-image-base
  > -L/usr/X11R6/lib -o temacs ecrt0.o dispnew.o frame.o scroll.o xdisp.o
  > xmenu.o window.o charset.o coding.o category.o ccl.o cm.o term.o
  > terminal.o xfaces.o xterm.o xfns.o xselect.o xrdb.o fontset.o xsmfns.o
  > fringe.o image.o  emacs.o keyboard.o macros.o keymap.o sysdep.o buffer.o
  > filelock.o insdel.o marker.o minibuf.o fileio.o dired.o filemode.o cmds.o
  > casetab.o casefiddle.o indent.o search.o regex.o undo.o alloc.o data.o
  > doc.o editfns.o callint.o eval.o floatfns.o fns.o print.o lread.o abbrev.o
  > syntax.o unexcw.o bytecode.o process.o callproc.o region-cache.o sound.o
  > atimer.o doprnt.o strftime.o intervals.o textprop.o composite.o md5.o
  > sheap.o terminfo.o gmalloc.o ralloc.o lastfile.o vm-limit.o  widget.o
  > mktime.o getloadavg.o   ../lwlib/liblw.a -L/usr/X11R6/lib -lXaw3d -lXmu
  > -lXt -lSM -lICE -lXext -ltiff -ljpeg -lpng -lz -lm -lungif -lXpm -lX11
  > -lcurses -lg  `gcc -print-libgcc-file-name` -lm -lc `gcc
  > -print-libgcc-file-name`
  > term.o: In function `dissociate_if_controlling_tty':
  > /tmp/emacs/src/term.c:3146: undefined reference to `_croak'
  > collect2: ld returned 1 exit status
  > make[2]: *** [temacs.exe] Error 1
  > make[2]: Leaving directory `/tmp/emacs/build/src'
  > make[1]: *** [bootstrap-build] Error 2
  > make[1]: Leaving directory `/tmp/emacs/build'
  > make: *** [bootstrap] Error 2
  > ---------------------------------------------------------------
  > 
  > (Note that term.c was one of the last update files before I checked out
  > CVS)
  > 
  > 
  > The same CVS bootstraps fine on GNU/Linux SLC4.
  > 
  > 
  > The CVS of 20070819 builds fine on both systems (linux and cygwin)

This is because the multi-tty branch got merged into emacs CVS
mainline. Most likely nobody tried it on cygwin before. Someone that
uses cygwin needs to take a look at what does it take to make it
compile again. Probably just a few #ifs need to be updated.

Re: Failure in building Emacs 23.0.50 on Cygwin

[Angelo Graziosi]

For the sake of completeness, using Emacs CVS 20070829 07:20 (cvs -z3
-d:pserver:anonymous@cvs.savannah.gnu.org:/sources/emacs co -P -D
"29 Aug 2007 7:20" emacs) bootstraps, while the CVS of few minutes later,
7:30, fails in bootstrapping as described.

It looks the problem is in src/term.c.


Cheers,

   Angelo.


On Wed, 29 Aug 2007, Dan Nicolaescu wrote:

> Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> writes:
>
>   > I have tried to bootstrap the last Emacs-23.0.50 CVS (checked out about an
>   > hour ago) on Cygwin, but it fails:
>
> [snip]
>
>   > gcc   -Wl,--enable-auto-import -Wl,--enable-auto-image-base
>   > -L/usr/X11R6/lib -o temacs ecrt0.o dispnew.o frame.o scroll.o xdisp.o
>   > xmenu.o window.o charset.o coding.o category.o ccl.o cm.o term.o
>   > terminal.o xfaces.o xterm.o xfns.o xselect.o xrdb.o fontset.o xsmfns.o
>   > fringe.o image.o  emacs.o keyboard.o macros.o keymap.o sysdep.o buffer.o
>   > filelock.o insdel.o marker.o minibuf.o fileio.o dired.o filemode.o cmds.o
>   > casetab.o casefiddle.o indent.o search.o regex.o undo.o alloc.o data.o
>   > doc.o editfns.o callint.o eval.o floatfns.o fns.o print.o lread.o abbrev.o
>   > syntax.o unexcw.o bytecode.o process.o callproc.o region-cache.o sound.o
>   > atimer.o doprnt.o strftime.o intervals.o textprop.o composite.o md5.o
>   > sheap.o terminfo.o gmalloc.o ralloc.o lastfile.o vm-limit.o  widget.o
>   > mktime.o getloadavg.o   ../lwlib/liblw.a -L/usr/X11R6/lib -lXaw3d -lXmu
>   > -lXt -lSM -lICE -lXext -ltiff -ljpeg -lpng -lz -lm -lungif -lXpm -lX11
>   > -lcurses -lg  `gcc -print-libgcc-file-name` -lm -lc `gcc
>   > -print-libgcc-file-name`
>   > term.o: In function `dissociate_if_controlling_tty':
>   > /tmp/emacs/src/term.c:3146: undefined reference to `_croak'
>   > collect2: ld returned 1 exit status
>   > make[2]: *** [temacs.exe] Error 1
>   > make[2]: Leaving directory `/tmp/emacs/build/src'
>   > make[1]: *** [bootstrap-build] Error 2
>   > make[1]: Leaving directory `/tmp/emacs/build'
>   > make: *** [bootstrap] Error 2
>   > ---------------------------------------------------------------
>   >
>   > (Note that term.c was one of the last update files before I checked out
>   > CVS)
>   >
>   >
>   > The same CVS bootstraps fine on GNU/Linux SLC4.
>   >
>   >
>   > The CVS of 20070819 builds fine on both systems (linux and cygwin)
>
> This is because the multi-tty branch got merged into emacs CVS
> mainline. Most likely nobody tried it on cygwin before. Someone that
> uses cygwin needs to take a look at what does it take to make it
> compile again. Probably just a few #ifs need to be updated.
>
>

Re: Failure in building Emacs 23.0.50 on Cygwin

[d.henman]

I confirm that I too, encounter the same problem reported by Angelo on cygwin

> term.o: In function `dissociate_if_controlling_tty':
> /tmp/emacs/src/term.c:3146: undefined reference to `_croak'


I believe, the problem is that "croak" is not being properly defined in the
"sysdep.c" file.  It is only manifested when trying to compile term.c which refers to croak.

How should one define "croak" in sysdep.c for "i686-pc-cygwin" to test this?
   Ref: config.log:Target: i686-pc-cygwin


Regards,
  darel henman

Re: Failure in building Emacs 23.0.50 on Cygwin

[Dan Nicolaescu]

"d.henman" <dhenman@gmail.com> writes:

  > I confirm that I too, encounter the same problem reported by Angelo on cygwin
  > 
  > > term.o: In function `dissociate_if_controlling_tty':
  > > /tmp/emacs/src/term.c:3146: undefined reference to `_croak'
  > 
  > 
  > I believe, the problem is that "croak" is not being properly defined in the
  > "sysdep.c" file.  It is only manifested when trying to compile term.c which refers to croak.
  > 
  > How should one define "croak" in sysdep.c for "i686-pc-cygwin" to test this?
  >    Ref: config.log:Target: i686-pc-cygwin

IMO the question should be asked the other way: how do you avoid
references to "croak". 

Adjust preprocessor code in dissociate_if_controlling_tty so that
croak is not used. Whether that is enough to make cygwin work, I don't
know. 

Re: Failure in building Emacs 23.0.50 on Cygwin

[d.henman]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]


Dan Nicolaescu <dann@ics.uci.edu> wrote:
> IMO the question should be asked the other way: how do you avoid
> references to "croak". 
> 
> Adjust preprocessor code in dissociate_if_controlling_tty so that
> croak is not used. Whether that is enough to make cygwin work, I don't
> know. 

Here is the patch I came up with to avoid a reference to croak on the
cygwin platform.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: term.c patch for cygwin --]
[-- Type: text/x-c, Size: 337 bytes --]

--- term.c	2007-08-30 06:46:50.000000000 +0900
+++ term.c.fixed	2007-09-01 10:39:51.906250000 +0900
@@ -3142,8 +3142,10 @@
         emacs_close (fd);
       sigunblock (sigmask (SIGTTOU));
 #else
+#ifndef CYGWIN
       /* Unknown system. */
       croak ();
+#endif  /* ! CYGWIN */
 #endif  /* ! TIOCNOTTY */
 #endif  /* ! USG */
     }

[-- Attachment #3: Type: text/plain, Size: 90 bytes --]


Please review this and let me know if I can check it into cvs.

Regards,
  Darel Henman


[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Failure in building Emacs 23.0.50 on Cygwin

[Eli Zaretskii]

> From: "d.henman" <dhenman@gmail.com>
> Date: Sat, 01 Sep 2007 12:53:13 +0900
> Cc: emacs-devel@gnu.org
> 
> --- term.c	2007-08-30 06:46:50.000000000 +0900
> +++ term.c.fixed	2007-09-01 10:39:51.906250000 +0900
> @@ -3142,8 +3142,10 @@
>          emacs_close (fd);
>        sigunblock (sigmask (SIGTTOU));
>  #else
> +#ifndef CYGWIN
>        /* Unknown system. */
>        croak ();
> +#endif  /* ! CYGWIN */
>  #endif  /* ! TIOCNOTTY */
>  #endif  /* ! USG */
>      }
> 
> --=-=-=
> 
> 
> Please review this and let me know if I can check it into cvs.

Please don't, as I think it;s the wrong way of fixing the problem.

I think the idea of defining `croak' for all platforms in sysdep.c is
a better one.

Re: Failure in building Emacs 23.0.50 on Cygwin

[d.henman]

I also feel that defining a "croak" for cygwin and all other platforms in sysdep.c is
 a better one.

After all that is what sysdep.c is for, I should think...

But, I don't have sufficient knowledge at this point, other thatn to make it functionwith no processing thet simply returns a zero, for o.k.

Regards,
  Darel Henman

Eli Zaretskii <eliz@gnu.org> wrote:

> > From: "d.henman" <dhenman@gmail.com>
> > Date: Sat, 01 Sep 2007 12:53:13 +0900
> > Cc: emacs-devel@gnu.org
> > 
> > --- term.c	2007-08-30 06:46:50.000000000 +0900
> > +++ term.c.fixed	2007-09-01 10:39:51.906250000 +0900
> > @@ -3142,8 +3142,10 @@
> >          emacs_close (fd);
> >        sigunblock (sigmask (SIGTTOU));
> >  #else
> > +#ifndef CYGWIN
> >        /* Unknown system. */
> >        croak ();
> > +#endif  /* ! CYGWIN */
> >  #endif  /* ! TIOCNOTTY */
> >  #endif  /* ! USG */
> >      }
> > 
> > --=-=-=
> > 
> > 
> > Please review this and let me know if I can check it into cvs.
> 
> Please don't, as I think it;s the wrong way of fixing the problem.
> 
> I think the idea of defining `croak' for all platforms in sysdep.c is
> a better one.

Re: Failure in building Emacs 23.0.50 on Cygwin

[Eli Zaretskii]

> From: "d.henman" <dhenman@gmail.com>
> Date: Sat, 01 Sep 2007 19:14:15 +0900
> Cc: "d. henman" <dhenman@gmail.com>,<dann@ics.uci.edu>,<emacs-devel@gnu.org>
> 
> 
> I also feel that defining a "croak" for cygwin and all other platforms in sysdep.c is
>  a better one.
> 
> After all that is what sysdep.c is for, I should think...
> 
> But, I don't have sufficient knowledge at this point, other thatn to make it functionwith no processing thet simply returns a zero, for o.k.

??? Why not do what it does on other platforms (i.e. say "not
implemented" and exit)?

If exiting is somehow counterproductive, you could signal an error
(which will throw to top level) instead.

Re: Failure in building Emacs 23.0.50 on Cygwin

[Dan Nicolaescu]

"d.henman" <dhenman@gmail.com> writes:

  > Dan Nicolaescu <dann@ics.uci.edu> wrote:
  > > IMO the question should be asked the other way: how do you avoid
  > > references to "croak". 
  > > 
  > > Adjust preprocessor code in dissociate_if_controlling_tty so that
  > > croak is not used. Whether that is enough to make cygwin work, I don't
  > > know. 
  > 
  > Here is the patch I came up with to avoid a reference to croak on the
  > cygwin platform.
  > 
  > 
  > --- term.c	2007-08-30 06:46:50.000000000 +0900
  > +++ term.c.fixed	2007-09-01 10:39:51.906250000 +0900
  > @@ -3142,8 +3142,10 @@
  >          emacs_close (fd);
  >        sigunblock (sigmask (SIGTTOU));
  >  #else
  > +#ifndef CYGWIN
  >        /* Unknown system. */
  >        croak ();
  > +#endif  /* ! CYGWIN */
  >  #endif  /* ! TIOCNOTTY */
  >  #endif  /* ! USG */
  >      }
  > 
  > 
  > Please review this and let me know if I can check it into cvs.

So In evect you are making dissociate_if_controlling_tty be an empty
function on cygwin. Is that the right thing to do for this platform?
If it is, then I think it would be cleaner to change
#ifdef WINDOWSNT 
to 
#if defined(WINDOWSNT) || defined(CYGWIN)

(BTW, does emacs work on cygwin after your patch?)

Re: Failure in building Emacs 23.0.50 on Cygwin

[Eli Zaretskii]

> From: Dan Nicolaescu <dann@ics.uci.edu>
> Date: Fri, 31 Aug 2007 17:35:58 -0700
> Cc: emacs-devel@gnu.org
> 
>   > > term.o: In function `dissociate_if_controlling_tty':
>   > > /tmp/emacs/src/term.c:3146: undefined reference to `_croak'
>   > 
>   > 
>   > I believe, the problem is that "croak" is not being properly defined in the
>   > "sysdep.c" file.  It is only manifested when trying to compile term.c which refers to croak.
>   > 
>   > How should one define "croak" in sysdep.c for "i686-pc-cygwin" to test this?
>   >    Ref: config.log:Target: i686-pc-cygwin
> 
> IMO the question should be asked the other way: how do you avoid
> references to "croak". 

I think this is not a good idea.  If multi-tty relies on `croak' to
flag features that various ports need to implement, then `croak'
should be available for all platforms, at least until such time as all
the main supported platforms implement all such features.
(Personally, I would leave `croak' in Emacs even after that, since
it's such a small function, but that's me.)

> Adjust preprocessor code in dissociate_if_controlling_tty so that
> croak is not used.

That's sweeping the problem under the carpet; not a good idea, IMO.