From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Masatake YAMATO Newsgroups: gmane.emacs.devel Subject: typo? in tty_supports_face_attributes_p Date: Mon, 06 Aug 2007 04:28:14 +0900 (JST) Message-ID: <20070806.042814.27081142.jet@gyve.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1186342158 30979 80.91.229.12 (5 Aug 2007 19:29:18 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 5 Aug 2007 19:29:18 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 05 21:29:15 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IHlms-0002Rd-63 for ged-emacs-devel@m.gmane.org; Sun, 05 Aug 2007 21:29:15 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IHlmp-00017r-Ox for ged-emacs-devel@m.gmane.org; Sun, 05 Aug 2007 15:29:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IHlmm-00017b-7u for emacs-devel@gnu.org; Sun, 05 Aug 2007 15:29:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IHlmh-00016x-Pt for emacs-devel@gnu.org; Sun, 05 Aug 2007 15:29:07 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IHlmh-00016u-L2 for emacs-devel@gnu.org; Sun, 05 Aug 2007 15:29:03 -0400 Original-Received: from mo11.iij4u.or.jp ([210.138.174.79]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IHlme-0007h2-OO for emacs-devel@gnu.org; Sun, 05 Aug 2007 15:29:02 -0400 Original-Received: by mo.iij4u.or.jp (mo11) id l75JSYN6005581; Mon, 6 Aug 2007 04:28:34 +0900 Original-Received: from localhost (h219-110-077-149.catv01.itscom.jp [219.110.77.149]) by mbox.iij4u.or.jp (mbox10) id l75JSPn7026351; Mon, 6 Aug 2007 04:28:31 +0900 X-Mailer: Mew version 5.2 on Emacs 22.1.50 / Mule 5.0 (SAKAKI) X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:76056 Archived-At: Can I ask you to review following patch? While reading xfaces.c, I found unsymmetrical code. I guess these are typos. However I could not find the way to reproduce a bug which these typos cause quickly. If you know well about these area, could you take your time to review this patch? Forgive me my lazyness. Thanks in advance. Masatake --- xfaces.c 26 7月 2007 14:28:01 +0900 1.362 +++ xfaces.c 06 8月 2007 04:19:02 +0900 @@ -6066,7 +6066,7 @@ val = attrs[LFACE_INVERSE_INDEX]; if (!UNSPECIFIEDP (val)) { - if (face_attr_equal_p (val, def_attrs[LFACE_UNDERLINE_INDEX])) + if (face_attr_equal_p (val, def_attrs[LFACE_INVERSE_INDEX])) return 0; /* same as default */ else test_caps |= TTY_CAP_INVERSE; @@ -6109,7 +6109,7 @@ bg = attrs[LFACE_BACKGROUND_INDEX]; if (STRINGP (bg)) { - Lisp_Object def_bg = def_attrs[LFACE_FOREGROUND_INDEX]; + Lisp_Object def_bg = def_attrs[LFACE_BACKGROUND_INDEX]; if (face_attr_equal_p (bg, def_bg)) return 0; /* same as default */