unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: [dalias@aerifal.cx: ansi-term \e[J causes spurious newline [revised report]]
Date: Fri, 03 Aug 2007 08:49:56 -0700	[thread overview]
Message-ID: <200708031550.l73Fo0xh010200@oogie-boogie.ics.uci.edu> (raw)
In-Reply-To: <87zm66o80a.fsf@stupidchicken.com> (Chong Yidong's message of "Wed\, 21 Mar 2007 12\:51\:01 -0400")

Chong Yidong <cyd@stupidchicken.com> writes:

  > > From: Rich Felker <dalias@aerifal.cx>
  > > Subject: ansi-term \e[J causes spurious newline [revised report]
  > > To: bug-gnu-emacs@gnu.org
  > >
  > > On versions of GNU emacs I have tested (21.1 and cvs unicode-2
  > > branch), the "ansi-term" terminal emulator (M-x ansi-term) exhibits
  > > incorrect terminal behavior when given the ESC [ J sequence. In
  > > addition to clearing to the end of the screen, it moves the cursor to
  > > the beginning of the next line if the cursor is not already at the
  > > beginning of a line. To test this, use the following shell command
  > > from a shell running in ansi-term:
  > >
  > > echo -e 'hello\e[Jworld'
  > >
  > > On a vt100/ansi/ecma compatible terminal, this should leave
  > > "helloworld" visible on the screen, with everything afterward cleared.
  > > On GNU emacs' ansi-term, it prints hello on one line and world on the
  > > next, after clearing to the end of the screen.
  > >
  > > Removing the calls to term-unwrap-line from term-erase-in-display (in
  > > term.el) fixes the problem, but I don't know if this has any bad
  > > side-effects.
  > 
  > Looking through the code, I think the calls to term-unwrap-line should
  > be removed.  The note in the docstring of term-erase-in-display that
  > it "should only be called when point is at the start of a screen line"
  > is also false; this condition generally doesn't hold in situations
  > where this function is called, and if we remove the term-unwrap-line
  > calls, it's not necessary at all.
  > 
  > Cursory testing seems to indicate that ansi-term behaves fine without
  > the term-unwrap-line calls.
  > 
  > What do you think?

I checked in a patch that I hope fixes the problem.

      parent reply	other threads:[~2007-08-03 15:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-19 18:10 [dalias@aerifal.cx: ansi-term \e[J causes spurious newline [revised report]] Richard Stallman
2007-03-21 16:51 ` Chong Yidong
2007-03-21 18:40   ` Dan Nicolaescu
2007-03-21 19:16     ` Chong Yidong
2007-03-21 20:16       ` Dan Nicolaescu
2007-03-22  2:36         ` Miles Bader
2007-03-22  3:22           ` Dan Nicolaescu
2007-03-22  3:44             ` Miles Bader
2007-03-22  5:08               ` Dan Nicolaescu
2007-03-22  6:08                 ` Miles Bader
2007-03-22  9:27                 ` Kim F. Storm
2007-03-22 17:06                   ` Dan Nicolaescu
2007-03-22 22:00                     ` Kim F. Storm
2007-03-22  5:01   ` Richard Stallman
2007-08-03 15:49   ` Dan Nicolaescu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200708031550.l73Fo0xh010200@oogie-boogie.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).